[docker] support for custom GITEA_CUSTOM env var #6608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: The default value for GITEA_CUSTOM is `/data/gitea`. Signed-off-by: Jakob Ackermann <[email protected]>
Signed-off-by: Jakob Ackermann <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #6608 +/- ##
=========================================
- Coverage 41.4% 41.4% -0.01%
=========================================
Files 441 441
Lines 59736 59736
=========================================
- Hits 24734 24733 -1
- Misses 31762 31764 +2
+ Partials 3240 3239 -1
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
|
@das7pad sorry I didn't see your PR previously. I will look at it. |
sapk
reviewed
Apr 17, 2019
sapk
approved these changes
Apr 17, 2019
GiteaBot
added
lgtm/need 1
The `GITEA_CUSTOM` environment variable is set globally in the `Dockerfile` and for ssh-sessions in `/data/git/.ssh/environment`. Signed-off-by: Jakob Ackermann <[email protected]>
…-custom # Conflicts: # docker/root/etc/profile.d/gitea.sh
zeripath
approved these changes
May 8, 2019
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a custom
GITEA_CUSTOMenvironment variable in a docker container.The current version has this path hardcoded to
/data/gitea.Environment changes trigger a recreation of the container and reset the profile script in
/etc/profile.d/gitea.sh. It is safe to replace the default path instead of the full line.The additional ssh-environment in
/data/git/.ssh/environmentis located in the users volume. Environment changes do not reset this file. This patch keeps additional variables a user may have placed there.The additional
chownon the initial config is needed to support paths like/etc/giteaand such, which are not writable by the git/run-user by default.