-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make gitea serv use api/internal #4886
Conversation
Git clone tests seems to fail now |
modules/private/key.go
Outdated
@@ -0,0 +1,116 @@ | |||
// Copyright 2017 The Gitea Authors. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2018
I have not much time until 2 weeks. I will look at tests since I test clone manually and it worked but I must have forget one corner case. |
3d2e752
to
3c3ff11
Compare
Codecov Report
@@ Coverage Diff @@
## master #4886 +/- ##
========================================
Coverage ? 37.5%
========================================
Files ? 310
Lines ? 45929
Branches ? 0
========================================
Hits ? 17226
Misses ? 26232
Partials ? 2471
Continue to review full report at Codecov.
|
I found the stupid mistake I made. 😑 |
Both hooks command also need to use api/internal. |
@lunny I will have to verify but hook seems to only use const in models and already use private (api/internal). |
@sapk Another PR to remove that is good. |
In order to limit concurrent access to database (mostly for SQLite)
Related: #4848 #2040