Fix only updated_unix when adding a comment #3855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
bkcsoft
added
the
lgtm/need 1
|
LGTM. CI fail is unrelated. |
techknowlogick
approved these changes
Apr 28, 2018
bkcsoft
added
lgtm/done
appleboy
approved these changes
Apr 28, 2018
|
#3856 will fix CI |
Codecov Report
@@ Coverage Diff @@
## master #3855 +/- ##
==========================================
- Coverage 23.02% 23.01% -0.01%
==========================================
Files 126 126
Lines 24894 24892 -2
==========================================
- Hits 5731 5729 -2
Misses 18287 18287
Partials 876 876
Continue to review full report at Codecov.
|
|
Please send a back port PR to v1.4 |
kolaente
added a commit
to kolaente/gitea
that referenced
this pull request
Apr 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes updating of the
created_unixcolumn of an issue when adding a comment.While working on #3794, I discovered this destroyed my routine to update an issue deadline as it updated everything (not only
created_unix), which lead to setting the deadline to the old deadline right after updating it to the new one.Previous pr which added this behavior was #2204.