Convert max file name length to 255 #30489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
github-actions
bot
added
the
modifies/templates
silverwind
approved these changes
Apr 15, 2024
GiteaBot
added
lgtm/need 1
yardenshoham
approved these changes
Apr 15, 2024
GiteaBot
added
lgtm/done
delvh
approved these changes
Apr 15, 2024
silverwind
added
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Apr 15, 2024
Quick/Partly fix go-gitea#29907 In Linux and MacOS, by default the max file name length is 255. In windows, it depends on the version and settings, and has no file name length limitation, but has path length limitation. By default it is 260, considering path length is longer than filename, so I think it is ok to do this. For Windows, see https://learn.microsoft.com/windows/win32/fileio/maximum-file-path-limitation?tabs=registry For Linux, see https://github.com/torvalds/linux/blob/master/include/uapi/linux/limits.h#L12-L13 For MacOS, see https://discussions.apple.com/thread/254788848?sortBy=best
GiteaBot
added
backport/done
silverwind
pushed a commit
that referenced
this pull request
Apr 15, 2024
Backport #30489 by @yp05327 Quick/Partly fix #29907 In Linux and MacOS, by default the max file name length is 255. In windows, it depends on the version and settings, and has no file name length limitation, but has path length limitation. By default it is 260, considering path length is longer than filename, so I think it is ok to do this. For Windows, see https://learn.microsoft.com/windows/win32/fileio/maximum-file-path-limitation?tabs=registry For Linux, see https://github.com/torvalds/linux/blob/master/include/uapi/linux/limits.h#L12-L13 For MacOS, see https://discussions.apple.com/thread/254788848?sortBy=best Co-authored-by: yp05327 <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 16, 2024
* giteaofficial/main: [skip ci] Updated translations via Crowdin Fix various overflows on actions view (go-gitea#30344) Convert max file name length to 255 (go-gitea#30489) Remove active border on pointing menu (go-gitea#30486) Fix button color on red and green buttons (go-gitea#30500) Fix code owners will not be mentioned when a pull request comes from a forked repository (go-gitea#30476) Fix overflow on issue dependency (go-gitea#30484) Kill all gitea processes before air build (go-gitea#30477)
wxiaoguang
added
the
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick/Partly fix #29907
In Linux and MacOS, by default the max file name length is 255.
In windows, it depends on the version and settings, and has no file name length limitation, but has path length limitation.
By default it is 260, considering path length is longer than filename, so I think it is ok to do this.
For Windows, see https://learn.microsoft.com/windows/win32/fileio/maximum-file-path-limitation?tabs=registry
For Linux, see https://github.com/torvalds/linux/blob/master/include/uapi/linux/limits.h#L12-L13
For MacOS, see https://discussions.apple.com/thread/254788848?sortBy=best