Remove jQuery class from the issue author dropdown #30188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switched from jQuery class functions to plain JavaScript `classList` - Tested the issue author dropdown functionality and it works as before Signed-off-by: Yarden Shoham <[email protected]>
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
yardenshoham
added
the
type/refactoring
delvh
approved these changes
Mar 30, 2024
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Mar 30, 2024
GiteaBot
added
lgtm/done
yardenshoham
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
wxiaoguang
reviewed
Mar 31, 2024
| } | ||
| $searchDropdown.dropdown('refresh'); | ||
| // defer our selection to the next tick, because dropdown will set the selection item after this `menu` function | ||
| setTimeout(() => { | ||
| $menu.find('.item.active, .item.selected').removeClass('active selected'); | ||
| $menu.find(`.item[data-value="${selectedUserId}"]`).addClass('selected'); | ||
| menu.querySelector('.item.active, .item.selected')?.classList.remove('active', 'selected'); |
There was a problem hiding this comment.
IIRC "active" and "selected" might point to different items. Mouse hover makes an item "active", "selected" means an item is the dropdown's value. In many cases it doesn't matter too much, while I think it's better to keep the old logic and make code more strict.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 31, 2024
* giteaofficial/main: Do not allow different storage configurations to point to the same directory (go-gitea#30169) Fix GPG subkey verify (go-gitea#30193) [skip ci] Updated translations via Crowdin Fix unclickable checkboxes (go-gitea#30195) Remove jQuery class from the issue author dropdown (go-gitea#30188) Remove jQuery class from the comment edit history (go-gitea#30186) Remove jQuery class from the repository branch settings (go-gitea#30184) [skip ci] Updated translations via Crowdin Use Crowdin action for translation sync (go-gitea#30054) Remove jQuery class from the project page (go-gitea#30183) Remove jQuery class from the comment context menu (go-gitea#30179)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
classList