Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check mysql database charset when installation #25411

Closed
wants to merge 1 commit into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 21, 2023

Fix #25378

@lunny lunny added type/bug backport/v1.20 This PR should be backported to Gitea 1.20 labels Jun 21, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 21, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 21, 2023
@wxiaoguang
Copy link
Contributor

It looks like a patch without a clear reason, not look good to me .......

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jun 21, 2023

The real bug is here (but it's still the root problem, the root problem is that the "install" page doesn't handle charset correctly)

image

@lunny lunny closed this Jun 21, 2023
@lunny lunny deleted the lunny/check_mysql_charset_install branch June 21, 2023 12:40
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/v1.20 This PR should be backported to Gitea 1.20 lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newly installed instance could use incorrect "utf8" charset for MySQL
3 participants