Support downloading raw task logs #24451

vitalif · 2023-04-30T21:20:23Z

Hi!
This pull request adds support for downloading raw task logs for Gitea Actions, similar to Github Actions
It looks like the following:

routers/web/repo/actions/view.go

yp05327 · 2023-05-01T09:05:49Z

What about the permission? Anyone who can access this page can download them?

web_src/js/components/RepoActionView.vue

wolfogre · 2023-05-04T03:48:54Z

What about the permission? Anyone who can access this page can download them?

IMO, yes. Since one can access this page, they should be able to see the log content on the page. So why can't they download the log file?

yp05327 · 2023-05-04T06:13:52Z

What about the permission? Anyone who can access this page can download them?

IMO, yes. Since one can access this page, they should be able to see the log content on the page. So why can't they download the log file?

Do these logs have secrets?
I’m not sure where we convert secrets into ‘*’

wolfogre · 2023-05-04T06:24:52Z

What about the permission? Anyone who can access this page can download them?

IMO, yes. Since one can access this page, they should be able to see the log content on the page. So why can't they download the log file?

Do these logs have secrets? I’m not sure where we convert secrets into ‘*’

The secrets in logs will be converted into *** by runners before the logs are sent to Gitea. Here it is: https://gitea.com/gitea/act_runner/src/commit/eef3c32eb2418dcbcd40cb13076c2887d4f6913b/internal/pkg/report/reporter.go#L415

routers/web/repo/actions/view.go

wolfogre · 2023-06-06T03:20:23Z

I have no more questions on the backend side, it works well on my environment. But I think there's still some room for improvement on the UI.

It doen't look well:

If it's unavailable to download, I can still click the button and get a text error page.
- Maybe the button should be disabled, and show a tooltip to explain why.

Not blocking, it doesn't really hurt. I'm OK to merge this first and improve it in another PR.

lunny · 2023-06-06T04:21:59Z

routers/web/repo/actions/view.go

+	defer reader.Close()
+
+	ctx.ServeContent(reader, &context_module.ServeHeaderOptions{
+		Filename:           job.Name + ".txt",


.log? Maybe the name should include the number.

I would do a pattern like $workflow-$job-$id.log.

silverwind · 2023-06-06T17:29:17Z

This alignment issue can be blamed on Fomantic UI. We could circumvent it by adding icons to all menu items. In case of "unchecked" state, we could create a gitea-empty.svg which is a SVG without any content, so it takes up space.

silverwind · 2023-06-06T18:13:09Z

This alignment issue can be blamed on Fomantic UI. We could circumvent it by adding icons to all menu items. In case of "unchecked" state, we could create a gitea-empty.svg which is a SVG without any content, so it takes up space.

Fixed in 228bc9b:

silverwind · 2023-06-06T18:17:46Z

Done with my fixes, leaving the rest to you @vitalif.

Co-authored-by: Jason Song <[email protected]>

vitalif · 2023-06-29T09:22:21Z

Oh, thanks for merging, I was thinking about fixing UI :)

silverwind · 2023-06-29T09:41:31Z

Still fixes outstanding? If so, needs a new PR :)

vitalif · 2023-06-29T10:14:21Z

Ok, no problem :)

yp05327 · 2023-07-31T02:23:28Z

Done with my fixes, leaving the rest to you @vitalif.

@silverwind
It seems that your fix in 228bc9b was broken by the force push here:
https://github.com/go-gitea/gitea/compare/ae9b3e969c843f6ac9025f5f080b67af907d4a24..aeb7759f88ad2a5951322d6b8691e9cbd1b0ca5e#diff-c3422631a14edbe1e508c4b22f0c718db318be08a6e889427802f9b6165d88d6R82

silverwind · 2023-07-31T09:26:59Z

I don't understand. Do we need to re-apply it in a separate PR?

yp05327 · 2023-08-01T00:04:36Z

I don't understand. Do we need to re-apply it in a separate PR?

@silverwind
The UI now is as the following and it looks strange:

Then I notice that you have improved it in 228bc9b
And it looks better:

The reason why we lost your patch is that after you push your code, it seems that @vitalif didn't notice that and made a force push to the branch:

And in this force push, your patch is recovered. So I think we should re-apply it in a separate PR.

silverwind · 2023-08-01T16:09:26Z

Indeed, the force-push eliminated my changes. Now this is rather hard to recover as all server-side data was destroyed. Maybe I still have it in my local reflog, need to check.

Maybe we should consider disabling force push for PR branches, if GitHub has such an option. I personally always force-push with --force-with-leases which ensures commits are never overwritten.

Edit: Luckily I linked the commit above, 90% sure it was only that single one.

silverwind · 2023-08-01T16:28:21Z

#26278

Ressurect lost changes from #24451. - Always show icons for each entry in the menu - Make all checkboxes toggle only their feature, e.g. "seconds" and "timestamps" can now be toggled on together. - Reorder the items <img width="845" alt="Screenshot 2023-08-01 at 19 19 27" src="https://github.com/go-gitea/gitea/assets/115237/8a76e9bf-7966-42a6-87c9-e88cdddaec82"> --------- Co-authored-by: Giteabot <[email protected]>

Hi! This pull request adds support for downloading raw task logs for Gitea Actions, similar to Github Actions It looks like the following: ![image](https://user-images.githubusercontent.com/945339/235376746-405d5019-710b-468b-8113-9e82eab8e752.png)

Ressurect lost changes from go-gitea#24451. - Always show icons for each entry in the menu - Make all checkboxes toggle only their feature, e.g. "seconds" and "timestamps" can now be toggled on together. - Reorder the items <img width="845" alt="Screenshot 2023-08-01 at 19 19 27" src="https://github.com/go-gitea/gitea/assets/115237/8a76e9bf-7966-42a6-87c9-e88cdddaec82"> --------- Co-authored-by: Giteabot <[email protected]>

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 30, 2023

pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 30, 2023

silverwind added type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/gitea-actions related to the actions of Gitea labels Apr 30, 2023

wxiaoguang reviewed May 1, 2023

View reviewed changes

routers/web/repo/actions/view.go Outdated Show resolved Hide resolved

silverwind reviewed May 1, 2023

View reviewed changes

web_src/js/components/RepoActionView.vue Outdated Show resolved Hide resolved

vitalif force-pushed the raw-task-logs branch 4 times, most recently from be9b329 to d64e0fd Compare June 5, 2023 10:05

wolfogre reviewed Jun 5, 2023

View reviewed changes

routers/web/repo/actions/view.go Outdated Show resolved Hide resolved

routers/web/repo/actions/view.go Outdated Show resolved Hide resolved

Support downloading raw task logs

44d2068

vitalif force-pushed the raw-task-logs branch from d64e0fd to 44d2068 Compare June 5, 2023 15:12

wolfogre reviewed Jun 6, 2023

View reviewed changes

routers/web/repo/actions/view.go Show resolved Hide resolved

lunny reviewed Jun 6, 2023

View reviewed changes

Update routers/web/repo/actions/view.go

aeb7759

Co-authored-by: Jason Song <[email protected]>

vitalif force-pushed the raw-task-logs branch from ae9b3e9 to aeb7759 Compare June 28, 2023 21:49

Generate log filenames as {workflow}-{job}-{taskID}.log

737c6e3

techknowlogick approved these changes Jun 28, 2023

View reviewed changes

GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 28, 2023

wolfogre approved these changes Jun 29, 2023

View reviewed changes

GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 29, 2023

wolfogre added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 29, 2023

Merge branch 'main' into raw-task-logs

31592e3

lunny added this to the 1.21.0 milestone Jun 29, 2023

lunny merged commit f0b773e into go-gitea:main Jun 29, 2023

GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 29, 2023

yp05327 mentioned this pull request Jul 31, 2023

Disable download action logs button when there's no logs #26114

Merged

silverwind mentioned this pull request Aug 1, 2023

Tweak actions menu #26278

Merged

go-gitea locked as resolved and limited conversation to collaborators Sep 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support downloading raw task logs #24451

Support downloading raw task logs #24451

vitalif commented Apr 30, 2023

yp05327 commented May 1, 2023

wolfogre commented May 4, 2023

yp05327 commented May 4, 2023 •

edited

Loading

wolfogre commented May 4, 2023 •

edited

Loading

wolfogre commented Jun 6, 2023

lunny Jun 6, 2023

silverwind Jun 6, 2023 •

edited

Loading

silverwind commented Jun 6, 2023 •

edited

Loading

silverwind commented Jun 6, 2023 •

edited

Loading

silverwind commented Jun 6, 2023

vitalif commented Jun 29, 2023

silverwind commented Jun 29, 2023 •

edited

Loading

vitalif commented Jun 29, 2023

yp05327 commented Jul 31, 2023

silverwind commented Jul 31, 2023

yp05327 commented Aug 1, 2023

silverwind commented Aug 1, 2023 •

edited

Loading

silverwind commented Aug 1, 2023

Support downloading raw task logs #24451

Support downloading raw task logs #24451

Conversation

vitalif commented Apr 30, 2023

yp05327 commented May 1, 2023

wolfogre commented May 4, 2023

yp05327 commented May 4, 2023 • edited Loading

wolfogre commented May 4, 2023 • edited Loading

wolfogre commented Jun 6, 2023

lunny Jun 6, 2023

Choose a reason for hiding this comment

silverwind Jun 6, 2023 • edited Loading

Choose a reason for hiding this comment

silverwind commented Jun 6, 2023 • edited Loading

silverwind commented Jun 6, 2023 • edited Loading

silverwind commented Jun 6, 2023

vitalif commented Jun 29, 2023

silverwind commented Jun 29, 2023 • edited Loading

vitalif commented Jun 29, 2023

yp05327 commented Jul 31, 2023

silverwind commented Jul 31, 2023

yp05327 commented Aug 1, 2023

silverwind commented Aug 1, 2023 • edited Loading

silverwind commented Aug 1, 2023

yp05327 commented May 4, 2023 •

edited

Loading

wolfogre commented May 4, 2023 •

edited

Loading

silverwind Jun 6, 2023 •

edited

Loading

silverwind commented Jun 6, 2023 •

edited

Loading

silverwind commented Jun 6, 2023 •

edited

Loading

silverwind commented Jun 29, 2023 •

edited

Loading

silverwind commented Aug 1, 2023 •

edited

Loading