Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Mention file extension for issue_template directory #20057

Merged
merged 3 commits into from
Jun 21, 2022
Merged

docs: Mention file extension for issue_template directory #20057

merged 3 commits into from
Jun 21, 2022

Conversation

s-hamann
Copy link
Contributor

I noticed that the docs on the issue templates directory do not mention the file extension requirement. This confused me and I had to dig in the code to find out, why my templates were not working.

This trivial PR addresses this.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 20, 2022
@techknowlogick techknowlogick added type/docs This PR mainly updates/creates documentation and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 20, 2022
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Jun 20, 2022
@6543 6543 added this to the 1.18.0 milestone Jun 20, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #20057 (d908a48) into main (1e2c2ed) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main   #20057    +/-   ##
========================================
  Coverage   46.94%   46.95%            
========================================
  Files         971      972     +1     
  Lines      134426   134530   +104     
========================================
+ Hits        63113    63175    +62     
- Misses      63589    63613    +24     
- Partials     7724     7742    +18     
Impacted Files Coverage Δ
modules/process/manager_exec.go 86.04% <0.00%> (-6.98%) ⬇️
modules/indexer/stats/indexer.go 51.06% <0.00%> (-6.39%) ⬇️
modules/notification/mail/mail.go 41.09% <0.00%> (-2.74%) ⬇️
modules/log/event.go 58.18% <0.00%> (-2.10%) ⬇️
modules/notification/ui/ui.go 58.92% <0.00%> (-1.79%) ⬇️
modules/queue/queue_bytefifo.go 50.18% <0.00%> (-1.45%) ⬇️
models/notification.go 62.22% <0.00%> (-1.10%) ⬇️
modules/markup/orgmode/orgmode.go 52.88% <0.00%> (ø)
models/issues/comment.go 50.43% <0.00%> (+0.10%) ⬆️
services/pull/pull.go 40.34% <0.00%> (+0.15%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e2c2ed...d908a48. Read the comment docs.

@6543
Copy link
Member

6543 commented Jun 21, 2022

🚀

@6543 6543 merged commit 7e733ee into go-gitea:main Jun 21, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 22, 2022
* giteaofficial/main:
  Update permissions.en-us.md (go-gitea#20075)
  Changelog for 1.16.9 (go-gitea#20059) (go-gitea#20063)
  Release page show all tags in compare dropdown (go-gitea#20070)
  docs: Mention file extension for issue_template directory (go-gitea#20057)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants