-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default host for different database #17873
Conversation
I think it can be fixed in https://github.com/go-gitea/gitea/blob/main/web_src/js/features/install.js Then we can have a unique behavior, instead of splitting code into backend and frontend. |
But that applies only to installation, what about already installed apps that just have this configuration wrong? I think certain duplication may be necessary. |
For installed config, if the HOST is lost, then the user's config file must have been corrupted, we should not guess a potential incorrect config option for the user either. Doing too many uncertain things will cause more troubles. |
I think it should go in as is ... the UI part is another thing - witch should be fixed by this too ... |
The UI is the key problem, the purpose of this PR is to make the install page show correct default database host, it can be fixed in JS clearly. If we do not want to fix the install UI, we do not need to patch anything. Changing the default values of the setting module in backend may bring some negative effects:
Since this PR was marked to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
marking as blocked per @wxiaoguang's feedback
replaced by #17919 |
When set
DBType
as postgres but leftHOST
empty, then the default value of host in installation page will become127.0.0.1:3306
. It's totally wrong.