Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SNAP Installation instructions #17040

Closed
wants to merge 15 commits into from
Closed

Conversation

osmosBe
Copy link

@osmosBe osmosBe commented Sep 14, 2021

Since I struggled a bit installing gitea with the snap package and finally managed to get it right I thought I would give something back to this project.
So I created a little guide and thought I add it to your Documentation.
I hope it can be useful for others and I hope it was the right way to get the snap working.

Since I struggled a bit installing gitea with the snap package and finally managed to get it right I thought I would give something back to this project.
So I created a little guide and thought I add it to your Documentation.
I hope it can be useful for others and I hope it was the right way to get the snap working.
docs/content/doc/installation/from-package.en-us.md Outdated Show resolved Hide resolved
docs/content/doc/installation/from-package.en-us.md Outdated Show resolved Hide resolved
docs/content/doc/installation/from-package.en-us.md Outdated Show resolved Hide resolved
docs/content/doc/installation/from-package.en-us.md Outdated Show resolved Hide resolved
docs/content/doc/installation/from-package.en-us.md Outdated Show resolved Hide resolved
docs/content/doc/installation/from-package.en-us.md Outdated Show resolved Hide resolved
docs/content/doc/installation/from-package.en-us.md Outdated Show resolved Hide resolved
docs/content/doc/installation/from-package.en-us.md Outdated Show resolved Hide resolved
docs/content/doc/installation/from-package.en-us.md Outdated Show resolved Hide resolved
docs/content/doc/installation/from-package.en-us.md Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 14, 2021
@6543 6543 added this to the 1.16.0 milestone Sep 14, 2021
@6543 6543 added the type/docs This PR mainly updates/creates documentation label Sep 14, 2021
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Sep 14, 2021
osmosBe and others added 4 commits September 15, 2021 08:53
Correcting some unclear descriptions in regards to MariaDB, MySQL and Database preperation
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@a959ed9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17040   +/-   ##
=======================================
  Coverage        ?   45.20%           
=======================================
  Files           ?      766           
  Lines           ?    86716           
  Branches        ?        0           
=======================================
  Hits            ?    39203           
  Misses          ?    41165           
  Partials        ?     6348           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a959ed9...2b0341e. Read the comment docs.

osmosBe and others added 4 commits September 15, 2021 09:56
Added reverence to reverse proxy information
Added a clearer description of how to secure gitea

Co-authored-by: wxiaoguang <[email protected]>
Added Information to some codeblocks if it is sh, nginx, sql etc.
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 16, 2021
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about this PR, the thing about the snap is that it is not dependent on anything else and can be just installed and is ready to go.

If users want something more advanced then other options are available to them.

@wxiaoguang
Copy link
Contributor

Maybe this snap method can be mereged into the package manager page, it is simple enough, while other steps are all covered by existing topics.

@osmosBe
Copy link
Author

osmosBe commented Sep 20, 2021

I'm unsure about this PR, the thing about the snap is that it is not dependent on anything else and can be just installed and is ready to go.

If users want something more advanced then other options are available to them.

The Problem with the snap instructions was, that I thought I could just install since there was no Information about the default port and that I needed an extra Database Setup etc.
Because most snap installations I did in the past where quite easy to setup and get running with the database and the config included or with some information on how to get it up and Running.
Maybe it is enough to reference the other topics or have another Page like Quickstart or Quicksetup where an overview of the needed components is given.
I know it's not that hard to use the snap and get it running but since the claim of this Project is: `The goal of this project is to provide the easiest, fastest, and most painless way of setting up a self-hosted Git service'. I think such a simple guide to get started is really usefull.

@axifive
Copy link
Member

axifive commented Sep 20, 2021

The Problem with the snap instructions was, that I thought I could just install since there was no Information about the default port and that I needed an extra Database Setup etc.

for sqlite not need extra Database Setup

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Sep 27, 2021

Snap installation has more issues, which should be fixed or documented.

Copy link
Contributor

@bagasme bagasme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have documentation for database setup and reverse proxy, so instead of duplicating the instructions you can simply point to those links.

@lunny lunny modified the milestones: 1.16.0, 1.17.0 Nov 19, 2021
@wxiaoguang
Copy link
Contributor

Thank you for your contribution.

After reading the document again, I found that most contents were already covered by existing document:

So this PR can be closed.

@wxiaoguang wxiaoguang closed this Apr 16, 2022
@wxiaoguang wxiaoguang removed this from the 1.17.0 milestone Jun 12, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants