Restore token authentication for git http when 2FA active #15915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a small regression in go-gitea#15303 whereby token auth with 2FA active would be disallowed. This PR fixes this. Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added
type/bug
issue/regression
6543
approved these changes
May 18, 2021
GiteaBot
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## main #15915 +/- ##
==========================================
- Coverage 44.02% 44.01% -0.01%
==========================================
Files 681 681
Lines 82336 82340 +4
==========================================
- Hits 36246 36243 -3
- Misses 40188 40193 +5
- Partials 5902 5904 +2
Continue to review full report at Codecov.
|
silverwind
approved these changes
May 18, 2021
GiteaBot
added
lgtm/done
6 tasks
6 tasks
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
…5915) There was a small regression in go-gitea#15303 whereby token auth with 2FA active would be disallowed. This PR fixes this. Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: 6543 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a small regression in #15303 whereby token auth
with 2FA active would be disallowed.
This PR fixes this.
Signed-off-by: Andrew Thornton [email protected]