Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review by commit dropdown (PR files changed tab) shows Committer not Author #29588

Closed
sebastian-sauer opened this issue Mar 4, 2024 · 2 comments · Fixed by #30272
Closed

Review by commit dropdown (PR files changed tab) shows Committer not Author #29588

sebastian-sauer opened this issue Mar 4, 2024 · 2 comments · Fixed by #30272
Labels
type/bug

Comments

@sebastian-sauer
Copy link
Contributor

Description

The review by commit dropdown in the PR files changed view shows the committer of a commit and not the author.
I think we should change this to the author as it is displayed in Commits tab of a PR.

Gitea Version

1.21.7

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Gitea Binary 1.21.7 downloaded via the official download site

Database

None
@sebastian-sauer
Copy link
Contributor Author

If this bug is "accepted" i'd by happy to provide a PR for this.

@delvh
Copy link
Member

delvh commented Mar 4, 2024

Sounds good to me

@sebastian-sauer sebastian-sauer mentioned this issue Apr 3, 2024
Merged
silverwind pushed a commit that referenced this issue Apr 5, 2024
@sebastian-sauer
Commit-Dropdown: Show Author of commit if available (#30272)
07bcfc1 
As in commits page we show the author of the commit in the commits
dropdown and not the committer.

Commits Page:
![Screenshot from 2024-04-03
22-34-41](https://github.com/go-gitea/gitea/assets/1135157/1c7c5c19-6d0a-4176-8a87-7bca6a0c6dc8)

and the same contents in our dropdown:

![image](https://github.com/go-gitea/gitea/assets/1135157/aa094af2-c369-47ac-9c27-ca208d1d03f0)


fixes #29588
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Apr 5, 2024
@sebastian-sauer @GiteaBot
Commit-Dropdown: Show Author of commit if available (go-gitea#30272)
0ed47e5 
As in commits page we show the author of the commit in the commits
dropdown and not the committer.

Commits Page:
![Screenshot from 2024-04-03
22-34-41](https://github.com/go-gitea/gitea/assets/1135157/1c7c5c19-6d0a-4176-8a87-7bca6a0c6dc8)

and the same contents in our dropdown:

![image](https://github.com/go-gitea/gitea/assets/1135157/aa094af2-c369-47ac-9c27-ca208d1d03f0)


fixes go-gitea#29588
@GiteaBot GiteaBot mentioned this issue Apr 5, 2024
Merged
silverwind pushed a commit that referenced this issue Apr 5, 2024
@GiteaBot @sebastian-sauer
Commit-Dropdown: Show Author of commit if available (#30272) (#30285)
c8570b7 
Backport #30272 by @sebastian-sauer

As in commits page we show the author of the commit in the commits
dropdown and not the committer.

Commits Page:
![Screenshot from 2024-04-03
22-34-41](https://github.com/go-gitea/gitea/assets/1135157/1c7c5c19-6d0a-4176-8a87-7bca6a0c6dc8)

and the same contents in our dropdown:

![image](https://github.com/go-gitea/gitea/assets/1135157/aa094af2-c369-47ac-9c27-ca208d1d03f0)


fixes #29588

Co-authored-by: sebastian-sauer <[email protected]>
AvengerMoJo pushed a commit to AvengerMoJo/gitea that referenced this issue Apr 8, 2024
@sebastian-sauer @AvengerMoJo
Commit-Dropdown: Show Author of commit if available (go-gitea#30272)
c5d75b0 
As in commits page we show the author of the commit in the commits
dropdown and not the committer.

Commits Page:
![Screenshot from 2024-04-03
22-34-41](https://github.com/go-gitea/gitea/assets/1135157/1c7c5c19-6d0a-4176-8a87-7bca6a0c6dc8)

and the same contents in our dropdown:

![image](https://github.com/go-gitea/gitea/assets/1135157/aa094af2-c369-47ac-9c27-ca208d1d03f0)


fixes go-gitea#29588
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 4, 2024
project-mirrors-bot-tu bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this issue Jan 23, 2025
@GiteaBot @earl-warren
Commit-Dropdown: Show Author of commit if available (go-gitea#30272) (g…
8a9b575 
…o-gitea#30285)

Backport go-gitea#30272 by @sebastian-sauer

As in commits page we show the author of the commit in the commits
dropdown and not the committer.

Commits Page:
![Screenshot from 2024-04-03
22-34-41](https://github.com/go-gitea/gitea/assets/1135157/1c7c5c19-6d0a-4176-8a87-7bca6a0c6dc8)

and the same contents in our dropdown:

![image](https://github.com/go-gitea/gitea/assets/1135157/aa094af2-c369-47ac-9c27-ca208d1d03f0)

fixes go-gitea#29588

Co-authored-by: sebastian-sauer <[email protected]>
(cherry picked from commit c8570b7)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Commit-Dropdown: Show Author of commit if available sebastian-sauer/gitea
2 participants
@sebastian-sauer @delvh