Already reviewed PRs are still listed on "Pull Requests" page #27019
Assignees
Labels
Comments
|
Sorry about that, It's a mistake introduced by my PR #26784. I will fix this one and add more tests. |
|
@lng2020 When this issue will be fixed? There is no milestone attached to this issue. |
I've made several PRs to refractor the unit tests about issues recently in order to solve the continuous bugs in the issue overview page. As you can see here(#27087) |
silverwind
pushed a commit
that referenced
this issue
Sep 21, 2023
fix #27019 ## testfixture yml 1. add issue20(a pr issue) in repo 23, org 17 2. add user15 to team 9 3. add four reviews about issue20 ## test case add two tests that are described with code comments the code before pr #26784 failed the first test <img width="479" alt="image" src="https://github.com/go-gitea/gitea/assets/70063547/1d9b5787-11b4-4c4d-931f-6a9869547f35"> current code failed the second test(as mentioned in #27019) <img width="484" alt="image" src="https://github.com/go-gitea/gitea/assets/70063547/05608055-7587-43d1-bae1-92c688270819"> Any advice is appreciated. --------- Co-authored-by: CaiCandong <[email protected]> Co-authored-by: Giteabot <[email protected]>
GiteaBot
added a commit
to GiteaBot/gitea
that referenced
this issue
Sep 21, 2023
fix go-gitea#27019 ## testfixture yml 1. add issue20(a pr issue) in repo 23, org 17 2. add user15 to team 9 3. add four reviews about issue20 ## test case add two tests that are described with code comments the code before pr go-gitea#26784 failed the first test <img width="479" alt="image" src="https://github.com/go-gitea/gitea/assets/70063547/1d9b5787-11b4-4c4d-931f-6a9869547f35"> current code failed the second test(as mentioned in go-gitea#27019) <img width="484" alt="image" src="https://github.com/go-gitea/gitea/assets/70063547/05608055-7587-43d1-bae1-92c688270819"> Any advice is appreciated. --------- Co-authored-by: CaiCandong <[email protected]> Co-authored-by: Giteabot <[email protected]>
silverwind
pushed a commit
that referenced
this issue
Sep 21, 2023
Backport #27104 by @lng2020 fix #27019 ## testfixture yml 1. add issue20(a pr issue) in repo 23, org 17 2. add user15 to team 9 3. add four reviews about issue20 ## test case add two tests that are described with code comments the code before pr #26784 failed the first test <img width="479" alt="image" src="https://github.com/go-gitea/gitea/assets/70063547/1d9b5787-11b4-4c4d-931f-6a9869547f35"> current code failed the second test(as mentioned in #27019) <img width="484" alt="image" src="https://github.com/go-gitea/gitea/assets/70063547/05608055-7587-43d1-bae1-92c688270819"> Any advice is appreciated. Co-authored-by: Nanguan Lin <[email protected]> Co-authored-by: CaiCandong <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
After reviewing PRs are still listed on "Pull Requests" -> "Review requested" page.
Before 1.20.4 only waiting to review PRs were listed on this page.
Reproduced on try.gitea.io
Gitea Version
1.20.4
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
Git Version
No response
Operating System
Debian 11
How are you running Gitea?
Selfhosted on Debian 11 + Gitea 1.20.4 + Nginx(for SSL) + PostgreSQL
Database
PostgreSQL
The text was updated successfully, but these errors were encountered: