-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can not edit/delete a file when its name starts with spaces #18176
Labels
Comments
I think the trim can safely be dropped |
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Jan 19, 2022
In go-gitea#5702 it was decided to trim preceding and suffixed spaces aswell as / from editing file filenames. This was because at this point in time the url-safety of gitea was much poorer. We can now drop this requirement and file editing should work correctly. Fix go-gitea#18176 Signed-off-by: Andrew Thornton <[email protected]>
zeripath
added a commit
that referenced
this issue
Jan 19, 2022
…18334) * Stop trimming preceding and suffixing spaces from editor filenames In #5702 it was decided to trim preceding and suffixed spaces aswell as / from editing file filenames. This was because at this point in time the url-safety of Gitea was much poorer. We can now drop this requirement and file editing should work correctly. Fix #18176 Signed-off-by: Andrew Thornton <[email protected]>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this issue
Mar 28, 2022
…o-gitea#18334) * Stop trimming preceding and suffixing spaces from editor filenames In go-gitea#5702 it was decided to trim preceding and suffixed spaces aswell as / from editing file filenames. This was because at this point in time the url-safety of Gitea was much poorer. We can now drop this requirement and file editing should work correctly. Fix go-gitea#18176 Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
cleanUploadFileName
functions%20a.txt
), then it can not be edited/deleted from the web UI@zeripath do you have any idea about why the spaces are trimmed? this change was introduced by #5702
gitea/routers/web/repo/editor.go
Lines 733 to 743 in ff2fd08
gitea/services/repository/files/file.go
Lines 129 to 140 in 719bddc
The text was updated successfully, but these errors were encountered: