Skip to content

Commit

Permalink
Remove useless appVer from JS window.config (#21445)
Browse files Browse the repository at this point in the history
The only usage of `appVer` was in serviceworker.js, while indeed it
needs the asset version.
  • Loading branch information
wxiaoguang authored Oct 13, 2022
1 parent 0e58201 commit f40833d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion templates/base/head_script.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ If you introduce mistakes in it, Gitea JavaScript code wouldn't run correctly.
<script>
window.addEventListener('error', function(e) {window._globalHandlerErrors=window._globalHandlerErrors||[]; window._globalHandlerErrors.push(e);});
window.config = {
appVer: '{{AppVer}}',
appUrl: '{{AppUrl}}',
appSubUrl: '{{AppSubUrl}}',
assetVersionEncoded: encodeURIComponent('{{AssetVersion}}'), // will be used in URL construction directly
Expand Down
4 changes: 2 additions & 2 deletions web_src/js/features/serviceworker.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {joinPaths, parseUrl} from '../utils.js';

const {useServiceWorker, assetUrlPrefix, appVer, assetVersionEncoded} = window.config;
const {useServiceWorker, assetUrlPrefix, assetVersionEncoded} = window.config;
const cachePrefix = 'static-cache-v'; // actual version is set in the service worker script
const workerUrl = `${joinPaths(assetUrlPrefix, 'serviceworker.js')}?v=${assetVersionEncoded}`;

Expand All @@ -25,7 +25,7 @@ async function invalidateCache() {
}

async function checkCacheValidity() {
const cacheKey = appVer;
const cacheKey = assetVersionEncoded;
const storedCacheKey = localStorage.getItem('staticCacheKey');

// invalidate cache if it belongs to a different gitea version
Expand Down

0 comments on commit f40833d

Please sign in to comment.