Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: option to set CSR emails #2423

Merged
merged 1 commit into from
Feb 6, 2025
Merged

feat: option to set CSR emails #2423

merged 1 commit into from
Feb 6, 2025
+131 −42

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 6, 2025

Fixes #2417

@ldez ldez added this to the unreleased milestone Feb 6, 2025
@ldez ldez requested a review from dmke February 6, 2025 02:19
dmke
dmke approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It would be nice if we had an ACME server which preserves the email address in the subject, so that the e2e test could verify that.

I guess Pebble not outright rejecting the CSR ought to be enough for now...

@ldez
Copy link
Member Author

ldez commented Feb 6, 2025

Yes, I also checked the log, and there is nothing.

@ldez ldez merged commit 4349dfc into go-acme:master Feb 6, 2025
7 checks passed
@ldez ldez deleted the feat/csr-emails branch February 6, 2025 18:00
@ldez ldez modified the milestones: unreleased, v4.22 Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmke dmke dmke approved these changes

Assignees
No one assigned
Labels
area/lib enhancement
Milestone
v4.22
Development

Successfully merging this pull request may close these issues.

Add option to add custom attributes to ACME CSR
2 participants
@ldez @dmke