Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve units and default values #2397

Merged
merged 4 commits into from
Jan 11, 2025
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented Jan 10, 2025

Improves xxx_POLLING_INTERVAL, xxx_PROPAGATION_TIMEOUT, xxx_TTL, xxx_HTTP_TIMEOUT, xxx_SEQUENCE_INTERVAL descriptions.

Related to #2395

Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't completed my review yet (Github requires me to "load diff" manually for the last ~100 changed file, which is exhausting), but so far I don't have complaints :)

Would you mind adding a .gitattributes file with the following contents?

**/zz_gen_*.*   linguist-generated

This should auto-collapse generated files in the diff view.

@ldez
Copy link
Member Author

ldez commented Jan 11, 2025

When I opened the PR I wondered if I should add an .gitattributes file.

tips: you can ctrl+click on the arrow at the beginning of a file to collapse all the files.

@dmke
Copy link
Member

dmke commented Jan 11, 2025

you can ctrl+click on the arrow at the beginning of a file to collapse all the files

That didn't work for me. Scrolling down a bit however, and checking the "viewed" box will jump me to the next file, and keep that file's "viewed" checkbox under the cursor.

@ldez
Copy link
Member Author

ldez commented Jan 11, 2025

Sorry this is Alt + click

@ldez ldez merged commit 5f69695 into go-acme:master Jan 11, 2025
7 checks passed
@ldez ldez deleted the fix/doc-times branch January 11, 2025 14:35
@dmke
Copy link
Member

dmke commented Jan 11, 2025

Hm, alt+click does collapse/expand all file panels, but it does not load the diff (which is kind of important ;-)).

@ldez
Copy link
Member Author

ldez commented Jan 11, 2025

The only trick to load all the files is a JS hack:

document.querySelectorAll('.load-diff-button').forEach(node => node.click())

@ldez ldez modified the milestones: unreleased, v4.22 Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants