-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve units and default values #2397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't completed my review yet (Github requires me to "load diff" manually for the last ~100 changed file, which is exhausting), but so far I don't have complaints :)
Would you mind adding a .gitattributes
file with the following contents?
**/zz_gen_*.* linguist-generated
This should auto-collapse generated files in the diff view.
When I opened the PR I wondered if I should add an tips: you can ctrl+click on the arrow at the beginning of a file to collapse all the files. |
That didn't work for me. Scrolling down a bit however, and checking the "viewed" box will jump me to the next file, and keep that file's "viewed" checkbox under the cursor. |
Sorry this is |
Hm, alt+click does collapse/expand all file panels, but it does not load the diff (which is kind of important ;-)). |
The only trick to load all the files is a JS hack: document.querySelectorAll('.load-diff-button').forEach(node => node.click()) |
Improves
xxx_POLLING_INTERVAL
,xxx_PROPAGATION_TIMEOUT
,xxx_TTL
,xxx_HTTP_TIMEOUT
,xxx_SEQUENCE_INTERVAL
descriptions.Related to #2395