Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS provider for Nodion #1844

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Add DNS provider for Nodion #1844

merged 3 commits into from
Feb 27, 2023

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 20, 2023

  • have a homogeneous design with the other providers
  • pass the linter
  • do go mod tidy
  • add tests (units)
  • add tests ("live")
  • add a provider descriptor
  • generate CLI help, documentation, and readme.
  • be able to do: (and put the output of this command to a comment)
$ NODION_API_TOKEN="xxx" \
./lego -m [email protected] --dns nodion -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run
2023/02/20 22:33:14 No key found for account [email protected]. Generating a P256 key.
2023/02/20 22:33:14 Saved key to /xxx.key
2023/02/20 22:33:14 Please review the TOS at https://letsencrypt.org/documents/LE-SA-v1.3-September-21-2022.pdf
Do you accept the TOS? Y/n
y
2023/02/20 22:33:16 [INFO] acme: Registering account for [email protected]
!!!! HEADS UP !!!!

Your account credentials have been saved in your Let's Encrypt
configuration directory at "/xxx/.lego/accounts".

You should make a secure backup of this folder now. This
configuration directory will also contain certificates and
private keys obtained from Let's Encrypt so making regular
backups of this folder is ideal.
2023/02/20 22:33:16 [INFO] [*.example.com, example.com] acme: Obtaining bundled SAN certificate
2023/02/20 22:33:17 [INFO] [*.example.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/5452189714
2023/02/20 22:33:17 [INFO] [example.com] AuthURL: https://acme-staging-v02.api.letsencrypt.org/acme/authz-v3/5452189724
2023/02/20 22:33:17 [INFO] [*.example.com] acme: use dns-01 solver
2023/02/20 22:33:17 [INFO] [example.com] acme: Could not find solver for: tls-alpn-01
2023/02/20 22:33:17 [INFO] [example.com] acme: Could not find solver for: http-01
2023/02/20 22:33:17 [INFO] [example.com] acme: use dns-01 solver
2023/02/20 22:33:17 [INFO] [*.example.com] acme: Preparing to solve DNS-01
2023/02/20 22:33:17 [INFO] [example.com] acme: Preparing to solve DNS-01
2023/02/20 22:33:17 [INFO] [*.example.com] acme: Trying to solve DNS-01
2023/02/20 22:33:18 [INFO] [*.example.com] acme: Checking DNS record propagation using [1.1.1.1:53]
2023/02/20 22:33:20 [INFO] Wait for propagation [timeout: 2m0s, interval: 2s]
2023/02/20 22:33:26 [INFO] [*.example.com] The server validated our request
2023/02/20 22:33:26 [INFO] [example.com] acme: Trying to solve DNS-01
2023/02/20 22:33:26 [INFO] [example.com] acme: Checking DNS record propagation using [1.1.1.1:53]
2023/02/20 22:33:28 [INFO] Wait for propagation [timeout: 2m0s, interval: 2s]
2023/02/20 22:33:28 [INFO] [example.com] The server validated our request
2023/02/20 22:33:28 [INFO] [*.example.com] acme: Cleaning DNS-01 challenge
2023/02/20 22:33:28 [INFO] [example.com] acme: Cleaning DNS-01 challenge
2023/02/20 22:33:28 [INFO] [*.example.com, example.com] acme: Validations succeeded; requesting certificates
2023/02/20 22:33:29 [INFO] [*.example.com] Server responded with a certificate.

Note the wildcard domain is important.

Closes #1661

@ldez ldez marked this pull request as draft February 20, 2023 20:58
@ldez ldez added this to the v4.11 milestone Feb 20, 2023
@ldez ldez marked this pull request as ready for review February 20, 2023 21:36
@nik736
Copy link

nik736 commented Feb 20, 2023

I tested it locally as well and it's working perfect. Thanks :)

@ldez ldez removed the state/need-user-tests Need users to test functionality label Feb 20, 2023
@ldez ldez requested a review from dmke February 20, 2023 21:54
Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, apart from the go.mod dependency.

@ldez ldez enabled auto-merge (squash) February 26, 2023 23:56
@ldez ldez merged commit cfafc8c into go-acme:master Feb 27, 2023
@ldez ldez deleted the feat/nodion branch February 27, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Support for provider: Nodion DNS
3 participants