fix: CNAME support #1735
Merged
fix: CNAME support #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmke
reviewed
Oct 12, 2022
ldez
force-pushed
the
fix/cname-dns
branch
2 times, most recently
from
df9cbd2 to
b642b90
Compare
|
Hi @ldez , Can we get a new release once this is merged? Much appreciated 🙏 |
|
@ooraini which provider are you using? |
|
@ldez I'm using OCI with the terraform provider 😅. I had to build the provider using my fork of lego. There are couple of commits fixing CNAME handling. I merely want get rid of my forks and use upstream directly 😬. Anyways, a 4.9.1 release would be appreciated and thanks for the amazing work.👏 |
3 tasks
|
ping @dmke |
|
Ah, shoot. This PR somehow went missing from my notifications, thanks for pinging me. I'll look into this, ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the created FQDN instead of the domain to be able to follow CNAME.
The following providers require changes to support CNAME, but it required a user of the provider to be able to change the code, so they are not in this PR: