Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update linter. #1305

Merged
merged 1 commit into from
Nov 24, 2020
Merged

chore: update linter. #1305

merged 1 commit into from
Nov 24, 2020

Conversation

ldez
Copy link
Member

@ldez ldez commented Nov 23, 2020

Update golangci-lint to v1.33.0.

The version is defined in the Travis settings.

@ldez ldez added this to the v4.2 milestone Nov 23, 2020
@ldez ldez requested a review from dmke November 23, 2020 23:22
dmke
dmke approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@dmke dmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Surpringly few godot corrections needed. :-)

@ldez ldez merged commit 8006c74 into go-acme:master Nov 24, 2020
@ldez ldez deleted the fix/update-linter branch November 24, 2020 08:38
@ldez ldez modified the milestones: v4.2, v4.1 Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmke dmke dmke approved these changes

Assignees
No one assigned
Labels
area/infrastructure enhancement
Milestone
v4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ldez @dmke