Skip to content

Commit

Permalink
chore: update linter (#1927)
Browse files Browse the repository at this point in the history
  • Loading branch information
ldez authored Jun 2, 2023
1 parent 35d80ed commit dac3a65
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
env:
GO_VERSION: '1.20'
GOLANGCI_LINT_VERSION: v1.52.2
GOLANGCI_LINT_VERSION: v1.53.1
HUGO_VERSION: 0.54.0
CGO_ENABLED: 0
LEGO_E2E_TESTS: CI
Expand Down
23 changes: 18 additions & 5 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,23 @@ linters-settings:
ignore-words:
- internetbs
depguard:
list-type: denylist
include-go-root: false
packages:
- github.com/pkg/errors
- github.com/instana/testify
rules:
main:
deny:
- pkg: "github.com/instana/testify"
desc: not allowed
- pkg: "github.com/pkg/errors"
desc: Should be replaced by standard lib errors package
tagalign:
align: false
order:
- xml
- json
- yaml
- yml
- toml
- mapstructure
- url
godox:
keywords:
- FIXME
Expand Down Expand Up @@ -124,6 +136,7 @@ linters:
- errchkjson
- nonamedreturns
- musttag # false-positive https://github.com/junk1tm/musttag/issues/17
- gosmopolitan # not relevant

issues:
exclude-use-default: false
Expand Down
2 changes: 1 addition & 1 deletion acme/api/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ func (a *Core) signedPost(uri string, content []byte, response interface{}) (*ht
return nil, fmt.Errorf("failed to post JWS message: failed to sign content: %w", err)
}

signedBody := bytes.NewBuffer([]byte(signedContent.FullSerialize()))
signedBody := bytes.NewBufferString(signedContent.FullSerialize())

resp, err := a.doer.Post(uri, signedBody, "application/jose+json", response)

Expand Down

0 comments on commit dac3a65

Please sign in to comment.