This repository was archived by the owner on Apr 28, 2022. It is now read-only.
Remove legacy fee #542
Merged
Remove legacy fee #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkgnosis
approved these changes
May 3, 2021
bh2smith
approved these changes
May 5, 2021
fleupold
force-pushed
the
remove_legacy_fee
branch
from
e794bb6 to
bdc07b8
Compare
fleupold
added a commit
that referenced
this pull request
May 10, 2021
#542 is causing issues with the frontend (cf. #569 and gnosis/gp-v2-trading-bot#22) This change changes the fee_validation logic back to just checking if a quote from the specified sell token was made in the last minute (not checking buy token and traded amount) ### Test Plan CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the legacy fee route and makes the "fee verification logic" upon order placement verify that the fee is actually valid for the given path / amount.
We should keep this change in staging for a while and make sure trades are still happening / we are not seeing errors because of fee estimation errors (as the check is now stricter than before)
Test Plan
Unit tests are still passing.