This repository was archived by the owner on Apr 28, 2022. It is now read-only.
Remove legacy fee from API #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anxolin that answers that question. LGTM we'll adapt it but @bh2smith please don't merge this into prod until gnosis/cowswap#1689 is closed (should be EOW max) |
|
@W3stside - Please note that this PR isn't removing the fee endpoint you are currently using but rather an even older double-legacy fee endpoint... |
|
You can also check in our metrics if an endpoint is still used and maybe nginx logs. |
|
@bh2smith ah ok got it thx |
vkgnosis
approved these changes
Oct 26, 2021
|
Thanks for the heads-up, and checking the stats if it was used! Once our API is public it can even be someone else using it. Good call removing! |
nlordell
added a commit
to cowprotocol/services
that referenced
this pull request
Apr 4, 2022
This reverts commit 98b0685.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1292, I stumbled upon a section of code with a
TODO - remove thisfrom back in May. I think it is safe to assume that the front end no longer depends on this. Tagging @anxolin , @alfetopito and @W3stside to double check.This Legacy fee endpoint has been deprecated since #574 (May 10, 2021)
According to Grafana this endpoint is not really being used. Anything that is using is has only ever been getting 404 responses for as long as the graph has history (October 10, 2021) - see here