Fee&OrderQuote Endpoint: Implemention with legacy logic.

[bh2smith]

Depends on #1169

based on the specification defined in #1143, we implement the fee calculating logic of the existing route along with the building of an Order Quote that is returned by this endpoint.

• Note that this also involved a refactor of the legacy fee endpoint to make us of the new one. For this we move the generic response method into the new file making it generically operate on all of OrderQuoteResponse, BuyResponse and SellResponse. We had to open up a few fields in the OrderQuote to be public so that we could convert OrderQuoteResponse into the legacy Buy/SellResponse types. Furthermore, now, the legacy fee endpoint requires and order_validator and makes use of partial order validation on the Partial Order constructed from a legacy buy/sell request. Hopefully this minimal data doesn't lead to an order validation Error (or else we may have to introduce a validation override flag of some sort).

Test Plan

• Run the api locally and make a request that returns an OrderQuoteResponse

With this api request

curl -X 'POST' \
  'http://localhost:8080/api/v1/quote' \
  -H 'accept: application/json' \
  -H 'Content-Type: application/json' \
  -d '{
  "sellToken": "0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2",
  "buyToken": "0x6810e776880c02933d47db1b9fc05908e5386b96",
  "receiver": "0x9008D19f58AAbD9eD0D60971565AA8510560ab41",
  "validTo": 1632933600,
  "appData": "0x0000000000000000000000000000000000000000000000000000000000000000",
  "partiallyFillable": false,
  "sellTokenBalance": "erc20",
  "buyTokenBalance": "erc20",
  "from": "0x9008D19f58AAbD9eD0D60971565AA8510560ab41",
  "kind": "sell",
  "sellAmountBeforeFee": "99999999999999999999"
}'

We get back the following response

{
  "from": "0x9008d19f58aabd9ed0d60971565aa8510560ab41",
  "sellToken": "0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2",
  "buyToken": "0x6810e776880c02933d47db1b9fc05908e5386b96",
  "receiver": "0x9008d19f58aabd9ed0d60971565aa8510560ab41",
  "sellAmount": "99999999999999999999",
  "buyAmount": "379816735088461143945",
  "validTo": 1632933600,
  "appData": "0x0000000000000000000000000000000000000000000000000000000000000000",
  "feeAmount": "31686440800600000",
  "kind": "sell",
  "partiallyFillable": false,
  "sellTokenBalance": "erc20",
  "buyTokenBalance": "erc20"
}

• Run the legacy API as well to ensure it still functions properly.

[codecov-commenter]

Codecov Report

Merging #1155 (e6c6054) into main (49430ee) will increase coverage by 0.26%.
The diff coverage is 80.36%.

@@            Coverage Diff             @@
##             main    #1155      +/-   ##
==========================================
+ Coverage   67.43%   67.69%   +0.26%     
==========================================
  Files         135      135              
  Lines       27799    28101     +302     
==========================================
+ Hits        18746    19023     +277     
- Misses       9053     9078      +25     

[nlordell]

Like the new OrderQuoter type! Just feel like it should be in post_quote module (as that is where its used and the logic that uses it lives).

Some issues with the OpenAPI spec.

Otherwise looks great to me!