Skip to content
This repository was archived by the owner on Apr 4, 2022. It is now read-only.

Signing status styles #866

Merged
merged 3 commits into from
Nov 24, 2021
Merged

Signing status styles #866

merged 3 commits into from
Nov 24, 2021

Conversation

alongoni
Copy link
Contributor

@alongoni alongoni commented Nov 23, 2021

Summary

Closes #843
Also I've added the "Cancelling" status following the suggestion from Elena (#612)
image

To Test

  1. Open the Signing StatusLabel component
  2. Open the Cancelling StatusLabel component

@github-actions
Copy link

@elena-zh
Copy link

elena-zh commented Nov 24, 2021

Hey @alongoni , can you add 'Cancelling' state to the Storybook?
I hope, that one day we will have it implemented under #612 task...

Itself 'Signing' status looks good to me now!

@alongoni alongoni self-assigned this Nov 24, 2021
@alongoni alongoni added app:Explorer Explorer App Protofire task to the protofire team labels Nov 24, 2021
@alongoni alongoni marked this pull request as ready for review November 24, 2021 14:08
@elena-zh
Copy link

Hey @alongoni , seems that 'Filled' status is missing now in the Storybook
image

@elena-zh
Copy link

@alongoni , nevermind.
I just needed to change the value in the dropdown
image

@alongoni alongoni requested a review from elena-zh November 24, 2021 15:56
Copy link
Contributor

@henrypalacios henrypalacios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just consider my observation.

| 'open'
| 'fullfilled'
| 'cancelled'
| 'cancelling'
Copy link
Contributor

@henrypalacios henrypalacios Nov 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this cancelling doesn't come from the API yet, maybe we can omit it or add a comment about it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@alongoni alongoni added the Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds label Nov 24, 2021
@mergify mergify bot merged commit e23e93d into develop Nov 24, 2021
@alfetopito alfetopito deleted the 843-signing-status-styles branch November 25, 2021 15:52
@henrypalacios henrypalacios mentioned this pull request Dec 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:Explorer Explorer App Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds Protofire task to the protofire team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.4.0] Display 'Signing' status nicer in reduced screens when a screen width is [1025-1065] px
4 participants