Skip to content
This repository was archived by the owner on Apr 4, 2022. It is now read-only.

[Explorer] Add copy buttons for traded token addresses #819

Merged
merged 4 commits into from
Nov 9, 2021
Merged

[Explorer] Add copy buttons for traded token addresses #819

merged 4 commits into from
Nov 9, 2021

Conversation

matextrem
Copy link
Contributor

Summary

Closes #802

Added copy to clipboard component for copying traded token addreses.

Screen Shot 2021-11-08 at 00 47 53

To Test

  1. Go to orders/<order id> page (i.e: 0xa2e6c6fe3a83080e0c911e3e75ef4fce8bddb2929f25685c9631255f88dcb6a704a66cbba0485d7b21af836f52b711401300fddb615f8e69)
  • You'll see copy to clipboard button next to traded tokens name in Amount row

@matextrem matextrem added the Protofire task to the protofire team label Nov 8, 2021
@matextrem matextrem self-assigned this Nov 8, 2021
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

elena-zh
elena-zh suggested changes Nov 8, 2021
View reviewed changes
Copy link

@elena-zh elena-zh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!
However, we should remove copy icon from xDAI/ETH tokens, I think
image

As they return 0xeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee as a copied value

OrderIDs for test https://pr819--gpui.review.gnosisdev.com/xdai/orders/0x59920c85de0162e9e55df8d396e75f3b6b7c2dfdb535f03e5c807731c31585eaff714b8b0e2700303ec912bd40496c3997ceea2b616d6710/

https://pr819--gpui.review.gnosisdev.com/rinkeby/orders/0x483e7fd137e1fae2f3b459c38e9359249833c600db3b270c42b7220909e84208ff714b8b0e2700303ec912bd40496c3997ceea2b61604c5e/

https://pr819--gpui.review.gnosisdev.com/orders/0xe72a219c40f46b18f235c43c4ec1143ee77ec3078279c42522f92c2ccae62a3d1f5b740436fc5935622e92aa3b46818906f416e9610d3025/

@matextrem matextrem requested a review from elena-zh November 8, 2021 16:37
elena-zh
elena-zh approved these changes Nov 8, 2021
View reviewed changes
Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

alfetopito
alfetopito reviewed Nov 8, 2021
View reviewed changes
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working very nice, and awesome catch by Elena, I would totally have missed that.

Comment regarding the component below

@matextrem matextrem requested a review from alfetopito November 9, 2021 04:15
@alfetopito alfetopito added the Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds label Nov 9, 2021
@mergify mergify bot merged commit 494472f into develop Nov 9, 2021
This was referenced Nov 16, 2021
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees

@matextrem matextrem

Labels
Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds Protofire task to the protofire team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add buttons for copying traded token addresses in the explorer.
3 participants
@matextrem @alfetopito @elena-zh