This repository was archived by the owner on Apr 4, 2022. It is now read-only.
Adding owner address useSearchingAnotherNetwork #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrypalacios
added
app:Explorer
|
|
Changes LGTM. Anyways, it is my personal opinion and should not affect merging this PR if it looks good to other team members. |
alfetopito
reviewed
Oct 25, 2021
There was a problem hiding this comment.
Few comments regarding the code below.
Regarding the behaviour, working quite nice!
Adding to the text suggestions:
- When there are no orders at all
"No orders found" - When there's order in a network other than the one searched for:
No orders found on <strong>xDai</strong>.
However, found orders on:
<a>Mainnet</a>
...etc, like you did
src/apps/explorer/components/OrdersTableWidget/useSearchInAnotherNetwork.tsx
Outdated
Show resolved
Hide resolved
src/apps/explorer/components/OrdersTableWidget/useSearchInAnotherNetwork.tsx
Outdated
Show resolved
Hide resolved
src/apps/explorer/components/OrdersTableWidget/useSearchInAnotherNetwork.tsx
Outdated
Show resolved
Hide resolved
src/apps/explorer/components/OrdersTableWidget/useSearchInAnotherNetwork.tsx
Outdated
Show resolved
Hide resolved
src/apps/explorer/components/OrdersTableWidget/useSearchInAnotherNetwork.tsx
Outdated
Show resolved
Hide resolved
src/apps/explorer/components/OrdersTableWidget/useSearchInAnotherNetwork.tsx
Outdated
Show resolved
Hide resolved
henrypalacios
force-pushed
the
768-try-find-another-network
branch
from
076b2b4 to
5fd3b38
Compare
henrypalacios
force-pushed
the
768-try-find-another-network
branch
from
5fd3b38 to
4d188e1
Compare
alfetopito
approved these changes
Oct 27, 2021
src/apps/explorer/components/OrdersTableWidget/useGetOrders.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Leandro Boscariol <[email protected]>
alfetopito
added
the
Auto-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #768
Proposal:
To test
No other network with orders
https://pr785--gpui.review.gnosisdev.com/address/0x000000000000000000000000000000000000dead
Only Mainnet
https://pr785--gpui.review.gnosisdev.com/xdai/address/0x2e3d4e8e9c3aa1576a5827558f21b256b2d140b1
XDai and Rinkeby
https://pr785--gpui.review.gnosisdev.com/address/0xFF714b8b0e2700303eC912BD40496C3997ceEa2b