Search by OrderId and Address account

[henrypalacios]

Summary

Closes #691

Proposal:

• Allow search by OrderId and Address Account
• Otherwise, show the not found page

To Test

1. Go to explorer search
   2.1 Search by Address account -> i.e: 0x04a66cbba0485d7b21af836f52b711401300fddb
   2.2 Search by Order Id -> i.e: 0x88537c74a03c324464d6c269d99b29e7289b105766c5368f77c76c241e1d5da8b6bad41ae76a11d10f7b0e664c5007b908bc77c9615b2dac

[github-actions]

• 🔭 Explorer: Explorer test app
• 🔒 Safe Swap App: Trade test app (add to your safe apps)
• 📈 Trade: Trade test app
• 📚 Storybook: Component stories

[elena-zh]

Changes LGTM: I'm able to search by an order ID and an address (full match).
But an address info is available in the Mainnet only, even if I search for it when the explorer is in XDAI network
https://watch.screencastify.com/v/UvUk0c1NJENLRponEaYG

I hope, it will be fixed in #747

[henrypalacios]

Thanks @elena-zh for the feedback, Then I think it is best to keep the URL network prefix in the search.
Let me try!

[alfetopito]

Looking good, loved the tests

Good idea updating the text placeholder. We should also update the header

And, I think we should change the behaviour a little bit when nothing is found.

With this PR, it goes to /search/whatever and we show the 404 page

But I think the best would be to update and use the currect /order/whatever path on /search/whatever

Same thing that you did here, update the texts/placeholders and use that on search

What do you think of that?

[alfetopito]

Changes LGTM: I'm able to search by an order ID and an address (full match). But an address info is available in the Mainnet only, even if I search for it when the explorer is in XDAI network https://watch.screencastify.com/v/UvUk0c1NJENLRponEaYG

I hope, it will be fixed in #747

It might be fixed by that, only if you are already in the network you want.

The "ultimate" fix would be to implement the address search like we have for order ids #711

In any case, at this point I'm ok not having that in favor of releasing it

[alfetopito]

Almost perfect

Only thing I'd like is to have the "not found" search results page to be under /search instead of /orders

Maybe this is a different task/PR?

I'm ok merging as is to keep the PR concise, if that change ends up being too big.

I'll leave it up to you to address that here or not

[alongoni]

Looks and

[alongoni]

Looks and works fine!

(Only one comment regarding search box on order not found page)

[henrypalacios]

@alfetopito I have tried to go for the not found change, but it is convenient to create another PR because it may alter other things.

[anxolin]

Awesome

[anxolin]

Not for this release, we really need it out, but maybe we can hint somehow the network the user is looking for orders.

For example, I used an account that only traded in Rinkeby, I looked for 0xe3a60C046Bcf663645d55EA7eD6E1eD167bd1dF0 and it shows:

One small thing we can do is to change the message to make sure the user is aware of the network he/she is in. Ideally with a way to switch networks easily. Probably this could be connected to the network switcher task.

Additionally, and as a good to have, the search algorithm could do exactly what the find by id is doing:

• Look in the current network
• If no results, try to find in another network
• if there's results, forward the user there

EXAMPLE:

• Has the user traded on mainnet? https://protocol-mainnet.dev.gnosisdev.com/api/v1/account/0xe3a60C046Bcf663645d55EA7eD6E1eD167bd1dF0/orders/?offset=0&limit=1
• No, continue. Has the user traded in xDAI: https://protocol-xdai.dev.gnosisdev.com/api/v1/account/0xe3a60C046Bcf663645d55EA7eD6E1eD167bd1dF0/orders/?offset=0&limit=1
• No, continue. Has the user traded in Rinkeby: https://protocol-rinkeby.dev.gnosisdev.com/api/v1/account/0xe3a60C046Bcf663645d55EA7eD6E1eD167bd1dF0/orders/?offset=0&limit=1
• YES! 🎉 --> Redirect user to https://pr752--gpui.review.gnosisdev.com/rinkeby/address/0xe3a60C046Bcf663645d55EA7eD6E1eD167bd1dF0/

[elena-zh]

Changes LGTM.
A tiny issue: to start 'order' word with the capital letter in the placeholder

[henrypalacios]

@anxolin I think the approach is great!

Not for this release, we really need it out, but maybe we can hint somehow the network the user is looking for orders.
...
Look in the current network
If no results, try to find in another network
if there's results, forward the user there

@alfetopito can I create a PR for this?

@elena-zh it's done!

[elena-zh]

Thanks!

[alfetopito]

@anxolin I think the approach is great!

Not for this release, we really need it out, but maybe we can hint somehow the network the user is looking for orders.
...
Look in the current network
If no results, try to find in another network
if there's results, forward the user there

@alfetopito can I create a PR for this?

Yes, please!

This is actually one of the follow ups I mentioned. Very good to have but not a blocker for the release