Skip to content
This repository was archived by the owner on Apr 4, 2022. It is now read-only.

Adding LinkWithPrefixNetwork #726

Merged
merged 4 commits into from
Oct 8, 2021
Merged

Adding LinkWithPrefixNetwork #726

merged 4 commits into from
Oct 8, 2021

Conversation

henrypalacios
Copy link
Contributor

@henrypalacios henrypalacios commented Oct 7, 2021

Summary

Closes #690

Proposal:

  • Check the current URL. Re-use whatever path after the base domain, if any
  • Create a LinkWithPrefixNetwork component to reuse

To Test

@henrypalacios henrypalacios self-assigned this Oct 7, 2021
@henrypalacios henrypalacios added app:Explorer Explorer App Protofire task to the protofire team labels Oct 7, 2021
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

@elena-zh
Copy link

elena-zh commented Oct 7, 2021

Hi @henrypalacios , cool! Changes LGTM!

However, some issues: I see several 404 issues in the console when an order is loaded
image
I understand that it is related to an order search in different networks, but anyways, seems to me a bit strange.

Moreover, when I manually change an order URL and expect to get an order not found page, I see the order in the network it placed =)
https://watch.screencastify.com/v/h3dj1xbxzJS3DrtlaOlH

However, it might be not a bug, just feature =)

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@alfetopito alfetopito requested a review from a team October 8, 2021 15:56
@alfetopito alfetopito added the Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds label Oct 8, 2021
@mergify mergify bot merged commit eeef670 into develop Oct 8, 2021
@henrypalacios henrypalacios deleted the 690-keep-network-link branch November 26, 2021 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:Explorer Explorer App Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds Protofire task to the protofire team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address links do not respect network
3 participants