-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
|
16e0f90
to
d3fae04
Compare
e539bc7
to
e6efdb5
Compare
@alfetopito What do you think about these options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you went a bit overboard here and added stuff we'll probably not need, but good to have anyway :)
About the storybook, when I pick something from the dropdown the selection doesn't change... 🤷 not a big deal if takes too long to fix
About the real table, add some padding/margin on the right. The dropdown glued to the border
Some minor comments/questions below.
Great job!
src/apps/explorer/components/OrdersTableWidget/PaginationOrdersTable.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily for this PR, but if we are adding this control, should we add it also to the query params when you change the default page size?
@anxolin You mean if I had the limiter set to 20 and I change the screen size we should adjust the limiter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Nice to have / UX improvement:
When the arrows are implemented, we should duplicate the component at the end of the order list.
Not quite. I believe he meant to update the URL with the preferred page size, in case for example if we reflect user's selection in the URL, so it's shareable: .../address/0x..../?pageSize=20 But as Anxo said, not for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only minor comments
src/apps/explorer/components/common/Dropdown/Drodown.stories.tsx
Outdated
Show resolved
Hide resolved
src/apps/explorer/components/common/Dropdown/Drodown.stories.tsx
Outdated
Show resolved
Hide resolved
74047e8
to
e9c59b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite. I believe he meant to update the URL with the preferred page size, in case for example if we reflect user's > selection in the URL, so it's shareable: .../address/0x..../?pageSize=20
But as Anxo said, not for now.
We can keep this in mind for later.
Yep, exactly as Leandro said. All good. Thanks
Summary
Closes #670
To Test