Skip to content
This repository was archived by the owner on Apr 4, 2022. It is now read-only.

[Sentry] source-maps support #657

Merged
merged 3 commits into from
Sep 22, 2021
Merged

Conversation

nenadV91
Copy link
Contributor

Summary

This will provide source maps support in sentry console which will make easier to debug errors in production.

131670516-1d3644ea-8ce5-4a55-9dfd-7b4e127ad6c5

To Test

  • source maps support should be visible in the sentry console after the deployment of source code with this valid sentry authToken

Background

  • the sentry-webpack-plugin will only be added if the REACT_APP_SENTRY_AUTH_TOKEN is defined as a env variable. The value of this variable is the authToken provided by sentry.

@github-actions
Copy link

@nenadV91 nenadV91 marked this pull request as ready for review September 20, 2021 10:54
@nenadV91 nenadV91 requested a review from a team September 20, 2021 10:54
@nenadV91 nenadV91 force-pushed the source-maps-in-sentry-support branch 3 times, most recently from ed3425b to fe290f8 Compare September 21, 2021 11:59
@anxolin anxolin self-requested a review September 21, 2021 16:34
@@ -25,11 +25,14 @@ import { version } from '../../../package.json'
const SENTRY_DSN = process.env.REACT_APP_SENTRY_DSN
const SENTRY_TRACES_SAMPLE_RATE = process.env.REACT_APP_SENTRY_TRACES_SAMPLE_RATE

console.log('React app sentry dsn', SENTRY_DSN)
console.log('GOOGLE_ANALYTICS_ID', process.env.GOOGLE_ANALYTICS_ID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to log these? Happy to do so if we really want. just asking

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this was just for debugging why there are no sentry issues for gp-ui. This will be removed.

@nenadV91 nenadV91 force-pushed the source-maps-in-sentry-support branch from b4b2650 to cc188d5 Compare September 22, 2021 09:28
@nenadV91 nenadV91 force-pushed the source-maps-in-sentry-support branch from d21841a to 7784311 Compare September 22, 2021 09:41
@nenadV91 nenadV91 force-pushed the source-maps-in-sentry-support branch from 7784311 to 97846c5 Compare September 22, 2021 10:03
@nenadV91 nenadV91 merged commit 549242f into develop Sep 22, 2021
@nenadV91 nenadV91 deleted the source-maps-in-sentry-support branch September 22, 2021 10:54
@alfetopito alfetopito mentioned this pull request Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants