This repository was archived by the owner on Apr 4, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1046 load from api orderstable #611
1046 load from api orderstable #611
Changes from 1 commit
ea58455
0b53823
3e36ca8
2f61d15
c848c44
66acfc9
bad76f6
649e7e6
cfdd5b3
36e7048
eb5d63f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about using a Set (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set) for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the Set, it would be much more readable however but I went for the
reduce
for performance.Do you think it makes up for it or should I go for the
Set
? https://jsben.ch/ognIgThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, no idea it had such a performance impact. Guess they make mose sense in languages where Sets are first class citizens.
I prefer sets for readability but maybe we should stick with reducer due to performance as you suggest.
@anxolin @W3stside FYI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had agreed on 30min but I have set it to 10min to test.