-
Notifications
You must be signed in to change notification settings - Fork 9
Create / Stylize Explorer-UserDetails Tab component #561
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the result with the custom theme, doesn't look too far off.
What is the problem you are having?
I have not been able to sync with @biocom yet, but maybe he has any input?
@alfetopito I have create another component using Tabs as a base. My concern is if I have to edit something to achieve in the future to use the space after the tabs for other components (as well as in design) |
@henrypalacios I think given we inherit the Tab component here, I think we need to edit the original component. Perhaps by having specifying different 'Tab' types? E.g. normal vs. special purpose. Remind me what was the design we are trying to implement? |
Thanks for you point of view @biocom, Looking at your last comment with the drawing of the boxes, you have hit the point. Following this:
I could place the other components next to the tabs (green box), but I'm not sure if I can get the |
justify-content: space-between; | ||
border: 1px dashed darkorange; | ||
|
||
.tab-extra-content { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alongoni Maybe you can help me make this work.
width: 100%; | ||
|
||
@media ${MEDIA.mobile} { | ||
display: none; /* for now we can hide the extra-content on mobiles */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should work on this in a new PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me.
Any comments @biocom ?
Looks good based on https://pr561--gpui.review.gnosisdev.com/storybook/?path=/story/explorerapp-explorertabs--default-tabs One comment is, what happens for mobile/responsive. E.g. the search/filters and tabs would need a solution for that. One idea is to turn the tabs into a select list/dropdown for mobile. Then column wrap all the items. Example https://ant.design/components/tabs/ Another idea is to only have these items:
This would prioritize the initial order details on mobile, and only show the filters on request. I'd be in favor of the latter idea. |
Due to last comment, what do you suggest @alfetopito? |
New PR. Since the desktop version is good to go, I'll merge it. |
closes: #1043