Skip to content
This repository was archived by the owner on Apr 4, 2022. It is now read-only.

Adding requests to the tenderly API #1057

Merged
merged 8 commits into from
Mar 18, 2022
Merged

Adding requests to the tenderly API #1057

merged 8 commits into from
Mar 18, 2022

Conversation

henrypalacios
Copy link
Contributor

@henrypalacios henrypalacios commented Feb 24, 2022

Summary

Closes #1056

Get data to draw graph about tenderly API from https://codesandbox.io/s/fmsoz (Credits to Felix)

It would be good to achieve here:

To Test:

@henrypalacios henrypalacios added app:Explorer Explorer App Protofire task to the protofire team labels Feb 24, 2022
@henrypalacios henrypalacios self-assigned this Feb 24, 2022
@henrypalacios henrypalacios changed the title Adding fetchTrace Adding requests to the tenderly API Feb 24, 2022
@github-actions
Copy link

@henrypalacios henrypalacios marked this pull request as ready for review March 3, 2022 19:21
@henrypalacios henrypalacios requested a review from alfetopito March 3, 2022 19:22
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine and the code looks good.

I'm just intrigued by the data itself from the example, which is probably out of the scope of your task, but anyway.

The ui/api response only has 1 order
https://pr1057--gpui.review.gnosisdev.com/tx/0xc2eb04b549d68c770062591e2561c5b1534ea665c6179d33a779c52376c9161d/

But when looking at the tx data and etherscan there are several more transfers https://etherscan.io/tx/0xc2eb04b549d68c770062591e2561c5b1534ea665c6179d33a779c52376c9161d

🤔

I'll ask the backend team about it

@henrypalacios henrypalacios requested a review from ramirotw March 8, 2022 13:02
@henrypalacios henrypalacios added the Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds label Mar 18, 2022
@mergify mergify bot merged commit e31c377 into develop Mar 18, 2022
@henrypalacios henrypalacios deleted the 1052-tenderly-api branch March 18, 2022 11:48
This was referenced Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:Explorer Explorer App Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds Protofire task to the protofire team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt code about tenderly API to run on Explorer
3 participants