This repository was archived by the owner on Apr 4, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
725d05e
to
a0f1a3b
Compare
a0f1a3b
to
52f8c3e
Compare
alfetopito
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work fine and the code looks good.
I'm just intrigued by the data itself from the example, which is probably out of the scope of your task, but anyway.
The ui/api response only has 1 order
https://pr1057--gpui.review.gnosisdev.com/tx/0xc2eb04b549d68c770062591e2561c5b1534ea665c6179d33a779c52376c9161d/
But when looking at the tx data and etherscan there are several more transfers https://etherscan.io/tx/0xc2eb04b549d68c770062591e2561c5b1534ea665c6179d33a779c52376c9161d
🤔
I'll ask the backend team about it
ramirotw
approved these changes
Mar 9, 2022
This was referenced Apr 1, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
app:Explorer
Explorer App
Auto-merge
PRs with this tag will be automatically merged when approved and CI succeeds
Protofire
task to the protofire team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1056
Get data to draw graph about tenderly API from https://codesandbox.io/s/fmsoz (Credits to Felix)
It would be good to achieve here:
traceToTransfersTrades
andcontractsInvolved
.To Test:
we will have a
console.log
with the settlement information.