Skip to content
This repository was archived by the owner on Apr 4, 2022. It is now read-only.

[Explorer] Make internal links open in the same tab - external links in another one #1029

Merged
merged 2 commits into from
Feb 5, 2022
Merged

[Explorer] Make internal links open in the same tab - external links in another one #1029

merged 2 commits into from
Feb 5, 2022

Conversation

matextrem
Copy link
Contributor

Summary

Closes #1020

Added _self to internal links to open same tab.
Added _blank to external links to open another tab.

To Test

  1. Open a page with links. i.e : address/0xb6bad41ae76a11d10f7b0e664c5007b908bc77c9
    • Click on a Token link or address next to the User Details title. Those links will be opened in another tab.
    • Click on an order link in the table. Those links will be opened in the same tab.

@matextrem matextrem added Enhancement New feature or request Protofire task to the protofire team Medium labels Feb 4, 2022
@matextrem matextrem self-assigned this Feb 4, 2022
@matextrem matextrem changed the base branch from develop to release/2.6.0 February 4, 2022 20:19
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

alfetopito
alfetopito approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels very nice 👍

henrypalacios
henrypalacios approved these changes Feb 5, 2022
View reviewed changes
Copy link
Contributor

@henrypalacios henrypalacios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got it ✔️

@henrypalacios henrypalacios added the Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds label Feb 5, 2022
@mergify mergify bot merged commit ef32c77 into release/2.6.0 Feb 5, 2022
@henrypalacios henrypalacios deleted the 1020/tab-links branch February 5, 2022 00:43
@henrypalacios henrypalacios mentioned this pull request Feb 5, 2022
Merged
@elena-zh
Copy link

elena-zh commented Feb 7, 2022

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito approved these changes

@henrypalacios henrypalacios henrypalacios approved these changes

@elena-zh elena-zh Awaiting requested review from elena-zh

Assignees

@matextrem matextrem

Labels
Auto-merge PRs with this tag will be automatically merged when approved and CI succeeds Enhancement New feature or request Medium Protofire task to the protofire team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make internal links opened in the same tab, external links in another tab
4 participants
@matextrem @elena-zh @alfetopito @henrypalacios