Skip to content
This repository was archived by the owner on Apr 4, 2022. It is now read-only.

Redirect to a user details page when follow the link /address/<ens domain format> #869

Closed
elena-zh opened this issue Nov 25, 2021 · 1 comment · Fixed by #888
Closed

Redirect to a user details page when follow the link /address/<ens domain format> #869

elena-zh opened this issue Nov 25, 2021 · 1 comment · Fixed by #888
Assignees
@henrypalacios
Labels
app:Explorer Explorer App Bug Something isn't working Medium Protofire task to the protofire team

Comments

@elena-zh
Copy link

Reported in #828 (comment)

  1. Redirect a user to the user details page when follow the link /address/<ens domain format, exists>
  2. Redirect a user to the /search page when follow the link /address/<ens domain format, does not exit>

Currently, user is redirected to the 404 page
@elena-zh elena-zh added app:Explorer Explorer App Protofire task to the protofire team Medium Bug Something isn't working labels Nov 25, 2021
@elena-zh elena-zh mentioned this issue Nov 25, 2021
Merged
@alfetopito alfetopito mentioned this issue Nov 30, 2021
Open
@alfetopito
Copy link
Contributor

Follow up task #884

@henrypalacios henrypalacios mentioned this issue Dec 3, 2021
Merged
@mergify mergify bot closed this as completed in #888 Dec 17, 2021
mergify bot pushed a commit that referenced this issue Dec 17, 2021
@henrypalacios
Adding resolveENS function and use on UserDetail Page (#888)
6f01516 
# Summary
Closes #869 

**Proposal:**
- Allow use `ENS` directly like URL as `/address/<ens_name>`

:warning: This solution prioritizes **Mainnet**, i.e. when searching `.../<network>/search/ensText.eth` it will search in **Mainnet**.

## To Test
- Visit `address` with valid :heavy_check_mark:  **ENS**
[/address/cosmoburn.eth](https://pr888--gpui.review.gnosisdev.com/address/cosmoburn.eth/)
- Visit `address` with Invalid 🔴  **ENS**
[/address/asereje.eth](https://pr888--gpui.review.gnosisdev.com/address/asereje.eth/)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@henrypalacios henrypalacios

Labels
app:Explorer Explorer App Bug Something isn't working Medium Protofire task to the protofire team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding resolveENS function and use on UserDetail Page gnosis/gp-ui
3 participants
@alfetopito @henrypalacios @elena-zh