Skip to content
This repository was archived by the owner on Apr 4, 2022. It is now read-only.

Mobile: make placeholder fully visible in the search field #770

Closed
elena-zh opened this issue Oct 15, 2021 · 3 comments · Fixed by #880
Closed

Mobile: make placeholder fully visible in the search field #770

elena-zh opened this issue Oct 15, 2021 · 3 comments · Fixed by #880
Assignees
@maria-vslvn
Labels
app:Explorer Explorer App Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system Protofire task to the protofire team

Comments

@elena-zh
Copy link

elena-zh commented Oct 15, 2021 •
edited
Loading

Related to #761
Placeholder is trimmed in the search field in a mobile view.
It would be nice to make if fully visible
image.png
@elena-zh elena-zh added app:Explorer Explorer App Protofire task to the protofire team Low Severity indicator for defects. It won't cause any major break-down of the system Bug Something isn't working labels Oct 15, 2021
@alfetopito
Copy link
Contributor

Suggestion: leave search by out on smaller screens

@maria-vslvn
Copy link
Contributor

@elena-zh @fapesteguia i can take it

@elena-zh
Copy link
Author

As an additional enhancement, make text a bit nicer (add line break/increase margins between lines?) in a mobile view:
image

@alfetopito , @alongoni , WDYT?

@maria-vslvn maria-vslvn self-assigned this Oct 22, 2021
@maria-vslvn maria-vslvn mentioned this issue Nov 30, 2021
Merged
@mergify mergify bot closed this as completed in #880 Dec 14, 2021
mergify bot pushed a commit that referenced this issue Dec 14, 2021
@maria-vslvn
replaced placeholder with el (#880)
bd1d864 
# Summary

Closes #770 
*High-level description of what your changes are accomplishing*

*Add screenshots if applicable. Images are nice :)*

# To Test

1. Open the page `home`
2. Decrease the screen width to 320px
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maria-vslvn maria-vslvn

Labels
app:Explorer Explorer App Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system Protofire task to the protofire team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replaced placeholder with el gnosis/gp-ui
3 participants
@alfetopito @maria-vslvn @elena-zh