This repository was archived by the owner on Apr 4, 2022. It is now read-only.

Simplify filled message #457

Closed

anxolin opened this issue Jun 2, 2021 · 0 comments · Fixed by #459

Assignees

Contributor

anxolin commented Jun 2, 2021 •

edited

Loading

When the order is untouched, I think we should drop the last part of this sentence:

0 WETH of 0.999999 WETH sold should be enough...

The text was updated successfully, but these errors were encountered:

alfetopito self-assigned this

alfetopito mentioned this issue

457/shorten filled message #459

Merged

mergify bot closed this as completed in #459

mergify bot pushed a commit that referenced this issue


          457/shorten filled message (#459)

4c23a33

# Summary

Closes #457 

Do not show opposite token when order is untouched
![screenshot_2021-06-03_15-08-10](https://user-images.githubusercontent.com/43217/120718021-7488a380-c47d-11eb-85da-e3a5346e92c8.png)

# Testing

## App

1. Load a fresh order
2. Check the filled text

## Storybook

1. Check the filled progress stories
![screenshot_2021-06-03_15-10-09](https://user-images.githubusercontent.com/43217/120718169-b6b1e500-c47d-11eb-8122-0d80e8c7f16f.png)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.