Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Approve by network #44

Merged
merged 6 commits into from
Dec 10, 2020
Merged

Approve by network #44

merged 6 commits into from
Dec 10, 2020

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Dec 9, 2020

The approve had the address hardcoded hardcoded

This PR:

  • Define the addresses of the contracts by network (uses GPv1 for now, since contracts are not deployed yet)
  • Overrides the hook involved in approving
  • Delegates to the "general" approve hook handing in the right address

@anxolin anxolin requested review from Velenir and W3stside December 9, 2020 14:50
Velenir
Velenir approved these changes Dec 9, 2020
View reviewed changes
@ghost
Copy link

ghost commented Dec 9, 2020

Travis automatic deployment:

  • 🎩 Dapp: Testing web app

@anxolin anxolin mentioned this pull request Dec 9, 2020
Merged
W3stside
W3stside approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@W3stside W3stside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, similar comments to dima

@anxolin anxolin merged commit 737758f into develop Dec 10, 2020
@anxolin anxolin deleted the approve-by-network branch July 2, 2021 13:52
@fairlighteth fairlighteth mentioned this pull request Feb 28, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Velenir Velenir Velenir approved these changes

@W3stside W3stside W3stside approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anxolin @Velenir @W3stside