This repository was archived by the owner on Jun 24, 2022. It is now read-only.
Price estimation Fee API #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis automatic deployment:
|
W3stside
force-pushed
the
price-estimation-fee-api
branch
from
78eb812 to
f90206f
Compare
Closed
W3stside
force-pushed
the
price-estimation-fee-api
branch
from
23dad10 to
57bf93f
Compare
W3stside
force-pushed
the
price-estimation-fee-api
branch
from
57bf93f to
c8519d3
Compare
W3stside
force-pushed
the
price-estimation-fee-api
branch
from
db2ca04 to
8a93d5a
Compare
Velenir
approved these changes
Dec 10, 2020
src/custom/state/fee/reducer.ts
Outdated
| } | ||
|
|
||
| const initialState: FeeInformationState = { | ||
| feesMap: {} |
There was a problem hiding this comment.
Should we also differentiate by chainId or do we count on token addresses not overlapping over diff networks?
There was a problem hiding this comment.
hmm true, likely will. @anxolin thoughts
There was a problem hiding this comment.
token addresses do overlap in different networks
W3stside
force-pushed
the
price-estimation-fee-api
branch
from
992d21a to
f47937b
Compare
W3stside
force-pushed
the
price-estimation-fee-api
branch
from
f47937b to
0e425a5
Compare
Velenir
approved these changes
Dec 18, 2020
W3stside
pushed a commit
that referenced
this pull request
Jun 28, 2021
add typechain generation for core/periphery contracts
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #32
Merges into #33
Summary
getFeefor grabbing FeeInformation object, passing sellToken address as arg