Gnosis safe app #2495
Gnosis safe app #2495
Conversation
|
CLA Assistant Lite: I have read the CLA Document and I hereby sign the CLA You can retrigger the CLA Action by commenting recheckcla in this Pull Request |
|
This reverts commit 67fc0a9.
| config.headers = { | ||
| 'Access-Control-Allow-Origin': '*', | ||
| 'Access-Control-Allow-Methods': 'GET', | ||
| 'Access-Control-Allow-Headers': 'X-Requested-With, content-type, Authorization', |
There was a problem hiding this comment.
Required to add CORS rules to debug locally
| @@ -161,6 +161,7 @@ | |||
| "scripts": { | |||
| "start:default": "craco start", | |||
| "start": "REACT_APP_DISABLE_TOKEN_WARNING=true yarn start:default", | |||
| "start:ssl": "HTTPS=true yarn start", | |||
There was a problem hiding this comment.
SSL is required to debug locally
anxolin
requested review from
nenadV91,
alfetopito,
W3stside,
fairlighteth and
a team
and removed request for
nenadV91
|
I'm still testing, works great in Rinkeby, still need to run some tests in Mainnet and GC. |
|
Works great! However, I'm not sure whether we can fix this (disable Swap button when the safe in the read-only mode). If yes, please let me know if I need to create a separate issue for this. Thanks |
|
Nice catch! I will try to address this one in a different PR (read only issue). I think we can do something |
|
Tested out the app with a Safe having a single owner, and also with a Safe with 2 owners. It was a very smooth user experience. Much better as compared using a WalletConnect bridge. One thing I missed from the Safe's end, was for a way to access the transaction One comment I have, is that the background seems blurred at all times: Not sure if this was intentional, but I believe we should disable this. In particular it interferes with any modal that adds another blur layer on top. |
|
@michelbio , regarding
please, review #2499 to see if it fixes it.
Yes, I think, that's mostly an issue with the Gnosis Safe, but we can try to ask if theres ways to improve |
anxolin
added
the
Auto-merge
There was a problem hiding this comment.
Working fine. Tested placing an order on rinkeby with a 2/n Safe.
The only caveat is the known issue regarding Safe information for devices other than the one that created the order.
For example, this is what the signer that created the order sees
And this is the other signer sees
|
@alfetopito , seems that the issue you have described is related to #1958 . Correct? |
|
same issue(s) as @alfetopito otherwise looks good! |
|
@elena-zh yes, that's the one. |
src/custom/hooks/web3.ts
Outdated
| export { useActiveWeb3React, useInactiveListener } from '@src/hooks/web3' | ||
| export { useInactiveListener } from '@src/hooks/web3' | ||
|
|
||
| export function useActiveWeb3React() { |
There was a problem hiding this comment.
Looks like this function stayed the same as the original one, is there a reason why we re-declared it here instead of just exporting it from the original like we did before?
Yep, other signers need to go to gnosis safe and they don't get this. It would be nice to add. I think is doable just by using the safe API and gettting the latest tx for the connected safe, but anyways, not prio. Good one for a community member. Is there an issue for this one? I would love to add a "help wanted" tag for all that have to do with the Gnosis Safe, i think is nice way to do contributions for the project |
Summary
Basic integration with Gnosis Safe Apps
I just gave it a small try, and since it was a low hanging fruit because we had most of it implemented I went for it (because of our Gnosis Safe implementation using Wallet Connect)
Basically, it does the following:
Not included
#2497 Remove disconnect and change wallet buttons
To Test
TODO: I will add instructions