Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Optimize bn.js package #2479

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Conversation

nenadV91
Copy link
Contributor

@nenadV91 nenadV91 commented Feb 20, 2022

Summary

Fixes #2449

This will make sure the bn.js package is included only once in production build instead of multiple times and reduce the size of the bundle

For reference https://stackoverflow.com/a/65119222/4620771

Before
Screenshot from 2022-02-20 15-59-42

After
Screenshot from 2022-02-20 16-00-33

To test

  • you can run yarn build:analyze to start webpack bundle analyzer

@github-actions
Copy link
Contributor

CLA Assistant Lite All Contributors have signed the CLA.

@nenadV91 nenadV91 requested a review from a team February 20, 2022 15:07
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@nenadV91 nenadV91 requested a review from a team February 21, 2022 11:46
@elena-zh
Copy link

hey @nenadV91 , I'm still testing, but here is the issue I have faced: when try to trade and get a native currency when connected to SC wallet (Safe), I get a different error in this pr:
safe xdai

Expected behavior:
expected

@elena-zh
Copy link

elena-zh commented Feb 21, 2022

It is appeared that the issue is not related to the Safe wallet: I get the same error when try to buy XDAI when connected to MM:
image

All the rest changes LGTM

@elena-zh
Copy link

@nenadV91 , I reported a separate issue for the comments above #2482 as the issue is not related to the current PR.

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa! Pure magic ✨

@nenadV91 nenadV91 merged commit 91acfe3 into 2449/reduce-dependencies Feb 23, 2022
@nenadV91 nenadV91 deleted the 2449/optimize-bn-package branch February 23, 2022 19:00
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants