Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Icons on activity details for claim #2356

Merged
merged 5 commits into from
Jan 31, 2022

Conversation

alfetopito
Copy link
Contributor

Summary

  • Added vCOW token on claim txs

  • Added USDC and GNO tokens to rinkeby and gchain

  • Removed unused components/images

    To Test

  1. Do approvals for GNO and USDC on rinkeby and gchain
  • Activity history should have image for them
  1. Do a claim on any network
  • Activity history should have vCOW token image

Note

GNO looks pretty bad on light mode and vCOW doesn't look good in either mode

| Screen Shot 2022-01-28 at 16 23 24 | Screen Shot 2022-01-28 at 16 23 03 |

@alfetopito alfetopito self-assigned this Jan 29, 2022
@alfetopito alfetopito requested review from a team January 29, 2022 00:41
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alfetopito , token icons are displayed in the activity modal now.
And yes, I agree that we should make vCOW icon more visible in the light theme, as well as GNO icon in the dark theme.
Maybe @biocom could help with this?

@fairlighteth
Copy link
Contributor

Addressing the vCOW icon in #2357

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, other than GNO looking like this in darkmode:

image

...but i think michel is looking into that

@anxolin
Copy link
Contributor

anxolin commented Jan 31, 2022

Merging, since the other issues are being addressed in a different PR

@anxolin anxolin merged commit f86ed9f into develop Jan 31, 2022
@alfetopito alfetopito deleted the icons-on-activity-details-for-claim branch January 31, 2022 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants