Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Optimise error messages (claim) #2351

Merged
merged 3 commits into from
Feb 1, 2022

Conversation

fairlighteth
Copy link
Contributor

Summary

  • Re-uses the ErrorMessage styled component to improve display of (validation) messages.
  • Distinguishes between 'danger' (error) messages and 'info' messages. This way errors are in better contrast with info messages.
  • Changed text on some of the validations. Feel free to amend/review.

Screen Shot 2022-01-28 at 18 24 37

Screen Shot 2022-01-28 at 18 24 07

Screen Shot 2022-01-28 at 18 23 55

Screen Shot 2022-01-28 at 18 20 14

Screen Shot 2022-01-28 at 18 20 02

Screen Shot 2022-01-28 at 18 19 07

Screen Shot 2022-01-28 at 18 17 57

Screen Shot 2022-01-28 at 18 17 47

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@alfetopito
Copy link
Contributor

I personally find that these colors (as well as the previous orange) do not have a good contrast on dark mode
Screen Shot 2022-01-28 at 10 24 13

Is it just me?

@elena-zh
Copy link

Hey @biocom , nice!

But as for @alfetopito I also think that it would be nice to make a better contrast for the messages in the dark mode.
Btw, I personally do not like 'pink' colors 😬. At least they remind me Uniswap colors...

Also, I'd like to propose to make these messages brighter to pay user's attention to them. WDYT?
image

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it very much. Approving, although agree on the comments above

@fairlighteth
Copy link
Contributor Author

Update the color red color for the different color modes. Also double check if the color contrast meets the contrast ratio AA score:
Screen Shot 2022-01-31 at 14 57 23
Screen Shot 2022-01-31 at 14 58 02
Screen Shot 2022-01-31 at 14 57 52


Screen Shot 2022-01-31 at 14 57 35

Screen Shot 2022-01-31 at 14 55 51

Screen Shot 2022-01-31 at 14 55 44

@fairlighteth
Copy link
Contributor Author

Pushed an updated to address @elena-zh 's comment on

Also, I'd like to propose to make these messages brighter to pay user's attention to them. WDYT?

Screen Shot 2022-01-31 at 17 32 47

Screen Shot 2022-01-31 at 17 32 39

@elena-zh
Copy link

elena-zh commented Feb 1, 2022

LGTM!

@fairlighteth fairlighteth changed the base branch from develop to release/1.10 February 1, 2022 10:21
@fairlighteth fairlighteth merged commit ed734b7 into release/1.10 Feb 1, 2022
@alfetopito alfetopito deleted the better-error-messages-claim branch February 1, 2022 17:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants