Don't show zero ammount message by default #2299
Conversation
|
|
still see it if not approved then approve. shows up |
|
@W3stside Updated so the approve doesn't count as touched. |
|
@anxolin Good point, changed to local state. I started with different solution that required redux but after forgot that I don't need it anymore. |
|
Looks great to me! I would adjust this generic error text and show it when any field on the form is in 'not touched' state. WDYT? Also, I would not show this error when the field is in the default state as well |
|
@elena-zh Added the generic message suggestion but kept the no balance error by default, Michel also thinks we should show this error msg and the field is disabled. |
|
Thanks, @nenadV91 ! Could you please fix it? |
|
@elena-zh Added Max button css fix. |
| @@ -221,6 +223,9 @@ export default function InvestmentFlow({ hasClaims, isAirdropOnly, modalCbs }: I | |||
| ))} | |||
|
|
|||
| {hasError && <InvestFlowValidation>Fix the errors before continuing</InvestFlowValidation>} | |||
| {!hasError && someNotTouched && ( | |||
| <InvestFlowValidation>Invest some amount of tokens for each option</InvestFlowValidation> | |||
There was a problem hiding this comment.
I would prefer something more generic than asking people to put money in hehe
| <InvestFlowValidation>Invest some amount of tokens for each option</InvestFlowValidation> | |
| <InvestFlowValidation>Required fields missing</InvestFlowValidation> |
What do you think @avsavsavs
There was a problem hiding this comment.
Wdyt of "Investment Amount is required to continue" If its too long, Then I would do "Investment Amount Required"
There was a problem hiding this comment.
Updated to Investment Amount is required to continue
Summary
Fixes #2285
I'm not really sure that we want this change but this is what I've got.