Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Added full amounts on hover for all claims values #2282

Merged
merged 3 commits into from
Jan 25, 2022

Conversation

alfetopito
Copy link
Contributor

Summary

Full amounts on hover for all claims values

Screen Shot 2022-01-24 at 16 57 26

  • No thousand separator

  • Not locale aware

  • Full precision for token amounts, 10 decimals for prices

    To Test

  1. On every claim step, hover over the values
  • It should show you the full precision value

Note: Only works on desktop and I am aware. Mobile might be addressed if we have time

@alfetopito alfetopito self-assigned this Jan 25, 2022
@alfetopito alfetopito requested review from a team January 25, 2022 01:00
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@elena-zh
Copy link

Hey @alfetopito , great changes!
Question: won't we add an amount on hover for 'Claiming' and 'Claimed!' screens?
image
image

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a note above.
Also, I have created an issue for showing full amounts in Mobile screens #2286

maria-vslvn pushed a commit that referenced this pull request Jan 25, 2022
@anxolin anxolin changed the base branch from develop to release/1.10 January 25, 2022 11:54
@alfetopito alfetopito force-pushed the full-claim-amounts-on-hover branch from 4f91d42 to 8b9cccd Compare January 25, 2022 18:39
@alfetopito
Copy link
Contributor Author

Hey @alfetopito , great changes! Question: won't we add an amount on hover for 'Claiming' and 'Claimed!' screens?

We should, thanks for find it.

Fixed.

@fairlighteth
Copy link
Contributor

Looks good. We're limited on time, but the title attributes could be further styled with a pseudo-element (https://jsfiddle.net/z42r2vv0/2/) - Tried a go at it, but a bit more involved than it's worth it at the moment :)

@alfetopito
Copy link
Contributor Author

Looks good. We're limited on time, but the title attributes could be further styled with a pseudo-element (https://jsfiddle.net/z42r2vv0/2/) - Tried a go at it, but a bit more involved than it's worth it at the moment :)

Low priority IMO.

We can revisit if we have time

@alfetopito alfetopito merged commit d1fbb50 into release/1.10 Jan 25, 2022
@alfetopito alfetopito deleted the full-claim-amounts-on-hover branch January 25, 2022 20:49
@elena-zh
Copy link

@alfetopito , Now I see full amounts on hover on 'Claiming' and 'Claimed!' screens.
Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants