-
Notifications
You must be signed in to change notification settings - Fork 54
Conversation
|
{allowToChangeAccount && hasActiveAccount ? ( | ||
<ButtonSecondary onClick={handleChangeAccount}>Change account</ButtonSecondary> | ||
) : ( | ||
!!account && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might as well make this it's on state const to or is this for TS complaining about account?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved based on code logic and app doing what your description claims. not sure if having to click twice now to switch to connect and then change is good but i'm fine with it
Hey @anxolin , Changes LGTM! |
I think that's the expected behaviour. |
Summary
This PR simplifies the logic of the buttons in the top part:
Hopefully, now the logic should be easier to read, and also how they work should be simpler too. The rules are:
Change account
and sometimesSwitch to connected account
. Now, only one of those will be visible. If you want to go back and use your connected wallet, normally you will need to first click on "change account", then in "Switch to connected account"Before
We used to show most of the times the two buttons

After
To Test