-
Notifications
You must be signed in to change notification settings - Fork 54
Lowercasing searched address to find it on chunk file #2260
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Approving, although, is better if @fedgiac gives the final approval so we agree on a consistent format for the addresses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. After the changes in here we'd have everything in lowercase for consistency, which includes:
- Filenames in the chunk folder
- Entries in mapping
- Keys in chunks
You can already test it in the branch 2022-01-22-test-deployment-all-networks
.
fa0442c
to
78caece
Compare
@alfetopito i hope u don't mind. I just updated the contract for GC in this PR, cause the data was changed, so we need to update the contract too so they match. EDIT: Nevermind, i saw #2262 changed the address. I just merged the two PRs togeter. Now running some minimal tests and consolidating into our |
New Gnosis Chain contract address
It looks pretty good! I think we can merge. We can continue testing in develop https://cowswap.dev.gnosisdev.com/#/swap The only issue i found is unrelated to this PR, i will fix it in a follow up. Basically the Etherscan link in GC points to mainnet. |
Summary
Fixing issue that causes addresses with claim not be shown in the UI
To Test
0x20026f06342e16415b070ae3bdb3983af7c51c95