Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Lowercasing searched address to find it on chunk file #2260

Merged
merged 6 commits into from
Jan 23, 2022

Conversation

alfetopito
Copy link
Contributor

@alfetopito alfetopito commented Jan 22, 2022

Summary

Fixing issue that causes addresses with claim not be shown in the UI

To Test

  1. On mainnet, search for the address 0x20026f06342e16415b070ae3bdb3983af7c51c95
  • It should show you 2 claims
  1. On dev (https://cowswap.dev.gnosisdev.com/), search for the same address
  • Without the fix you won't see any claim for it

@alfetopito alfetopito self-assigned this Jan 22, 2022
@alfetopito alfetopito requested review from a team January 22, 2022 19:23
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Approving, although, is better if @fedgiac gives the final approval so we agree on a consistent format for the addresses.

Copy link
Contributor

@fedgiac fedgiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. After the changes in here we'd have everything in lowercase for consistency, which includes:

  • Filenames in the chunk folder
  • Entries in mapping
  • Keys in chunks

You can already test it in the branch 2022-01-22-test-deployment-all-networks.

@alfetopito alfetopito force-pushed the fix-claim-chunk-search branch from fa0442c to 78caece Compare January 22, 2022 22:40
@anxolin
Copy link
Contributor

anxolin commented Jan 23, 2022

@alfetopito i hope u don't mind. I just updated the contract for GC in this PR, cause the data was changed, so we need to update the contract too so they match.

EDIT: Nevermind, i saw #2262 changed the address. I just merged the two PRs togeter. Now running some minimal tests and consolidating into our develop

@anxolin
Copy link
Contributor

anxolin commented Jan 23, 2022

It looks pretty good! I think we can merge. We can continue testing in develop https://cowswap.dev.gnosisdev.com/#/swap

The only issue i found is unrelated to this PR, i will fix it in a follow up. Basically the Etherscan link in GC points to mainnet.

@anxolin anxolin merged commit bb7b1a1 into develop Jan 23, 2022
@alfetopito alfetopito deleted the fix-claim-chunk-search branch January 23, 2022 21:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants