Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Add moo sounds #2259

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Add moo sounds #2259

merged 1 commit into from
Jan 24, 2022

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Jan 22, 2022

Summary

🐮 Just for fun, went for adding sound to the claiming and the success of it.

Includes a small refactor moving the sounds to an util, so they can be easily used in other parts of the app.

To Test

  1. Make sure your speakers are MAX_VOLUME!
  2. Claim

@anxolin anxolin requested review from a team January 22, 2022 17:33
@github-actions
Copy link
Contributor

  • 🔭 GP Swap: CoW Protocol v2 Swap UI

@anxolin
Copy link
Contributor Author

anxolin commented Jan 24, 2022

Merging, please review after merging. Will address issues

@anxolin anxolin merged commit aa5a8a2 into develop Jan 24, 2022
@alfetopito alfetopito deleted the add-mooo-sounds branch January 24, 2022 18:12
@elena-zh
Copy link

Works great!
The only think I noticed, that the same sound is playing when a transaction is failed and is successful.
I think, it would be nice to differentiate these sounds OR not to play a sound on fail at all.
I will add this into #2082 issue

maria-vslvn pushed a commit that referenced this pull request Jan 25, 2022
* upgrade to 7.0

* first iteration of stubbing subgraph in integration tests

* added fixtures

* add tests for fee tier distribution and liquidity chart

* remove unused test utils

* update yarn.lock

* fixed merge artifacts
maria-vslvn pushed a commit that referenced this pull request Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants