Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Claim style improve 20 #2232

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Claim style improve 20 #2232

merged 3 commits into from
Jan 20, 2022

Conversation

fairlighteth
Copy link
Contributor

@fairlighteth fairlighteth commented Jan 20, 2022

Summary

  • Styling of investing summary table
  • Progress bar styling
  • Replace GNO icon with more recent one
  • Adding xDAI logo image. Needs to be linked up with @alfetopito PR where he commented xDAI out for now.
  • General image compression
Screen.Recording.2022-01-20.at.14.05.16.mov

Screen Shot 2022-01-20 at 14 06 31

Todo:

  • Improve styles a bit more on the summary table. Mainly spacing things out.
  • Decide on what content to show. I suggested to inform the user on each investment, that they cannot invest the remaining amount after claiming. This is only shown on <100 or >0 percentage numbers.

Screen Shot 2022-01-20 at 14 07 05

@fairlighteth fairlighteth requested review from a team January 20, 2022 13:10
@fairlighteth
Copy link
Contributor Author

fairlighteth commented Jan 20, 2022

Noticed the % string missing in the progress bar, when on the investing summary (last) page. This happens only on smaller percentage numbers.

@fairlighteth
Copy link
Contributor Author

Noticed the % string missing in the progress bar, when on the investing summary (last) page. This happens only on smaller percentage numbers.

A fix has been pushed to solve for this:

@github-actions
Copy link
Contributor

  • 🔭 GP Swap: Gnosis Protocol v2 Swap UI

@elena-zh
Copy link

Hey @biocom , will it be fixed when responsive views are implemented?
image

@fairlighteth
Copy link
Contributor Author

When you selected an investment, but end up not investing at all
Screen Shot 2022-01-20 at 14 23 11

we could still show the row. But then emphasize that you won't be able to invest later. Something like this message:
Screen Shot 2022-01-20 at 14 23 39

And perhaps hide the progress bar (when 0%).

What do you think?

@elena-zh
Copy link

I would disable 'Review' button when one of the selected options has 0 amount..
image

And one of the selected options does not have an 'approved' token

@elena-zh
Copy link

Could we please round this amount to 2 decimals?
image

@elena-zh
Copy link

Also, I still think that it would be great to make this text left-aligned
image

@alfetopito
Copy link
Contributor

When you selected an investment, but end up not investing at all Screen Shot 2022-01-20 at 14 23 11

we could still show the row. But then emphasize that you won't be able to invest later. Something like this message: Screen Shot 2022-01-20 at 14 23 39

And perhaps hide the progress bar (when 0%).

What do you think?

This will not be possible when we implement the proper validations, so don't worry about handling it as a special case

Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

I say we merge as is (after rebasing against develop) and I can address the pending code related comments in a follow up PR

@fairlighteth fairlighteth changed the base branch from claim to develop January 20, 2022 16:54
@fairlighteth fairlighteth merged commit ef171d2 into develop Jan 20, 2022
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ pretty!

@alfetopito alfetopito deleted the claim-styleImprove-20 branch January 20, 2022 17:17
@alfetopito alfetopito mentioned this pull request Jan 20, 2022
maria-vslvn pushed a commit that referenced this pull request Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants